search

cuspaceflight / bamboo

Cooling system modelling for liquid rocket engines.
GNU Affero General Public License v3.0
16 stars 4 forks source link

Coolprop Brent method #13

Closed HenryFree3 closed 3 years ago

HenryFree3 commented 3 years ago

Root solver crashes with small cooling channels. Seems like the cause is the roots become too close together for whatever its solving, so there can be an even number of roots - it checks the product of the value of the function at the start and end of the interval and concludes if there's no change in sign, then there must be no root.

HenryFree3 commented 3 years ago

Misdiagnosed the original issue - the problem was coolant pressure dropping below 0