cuspaceflight / bamboo

Cooling system modelling for liquid rocket engines.
GNU Affero General Public License v3.0
16 stars 4 forks source link

Transient stress analysis for vertical channels #25

Closed hf360F closed 3 years ago

hf360F commented 3 years ago

There are some other changes besides the additions to the Engine.run_stress_analysis() method:

dug20 commented 3 years ago

Looks awesome, will update the docs soon.

Might be worth making outer liner a kwarg, so you can run heating simulations without it, but then have it raise an error if you try to run a stress simulation and it's unspecified. Although not a big issue so might not be worth it if it's troublesome.

hf360F commented 3 years ago

That was originally how I had it, I've now changed it back