search

cuspaceflight / bamboo

Cooling system modelling for liquid rocket engines.
GNU Affero General Public License v3.0
16 stars 4 forks source link

Make the outer liner argument optional for CoolingJacket? #26

Closed dug20 closed 3 years ago

dug20 commented 3 years ago

Not a big deal, was just wondering if it'd be worth doing, since it isn't necessary for heat transfer simulations.

hf360F commented 3 years ago

I thought I had done this (https://github.com/cuspaceflight/bamboo/pull/25) but hadn't made the outer liner thickness optional in 'add_geometry`