search

cuspaceflight / bamboo

Cooling system modelling for liquid rocket engines.
GNU Affero General Public License v3.0
16 stars 4 forks source link

'Mixture' object has no attribute 'calculate' #27

Closed henryefranks closed 3 years ago

henryefranks commented 3 years ago

I seem to get this error on two different machines, both running linux. It comes from the calls to self.thermo_object.calculate in cooling.py when thermo_object is an instance of thermo.mixture.Mixture, I think it's something to do with the thermo module installation but I'm not sure.

dug20 commented 3 years ago

thermo module just got updated yesterday - they seem to have revamped the whole thing. That's likely what's causing the issue.

henryefranks commented 3 years ago

Ok, had a quick go at some drop-in replacements (ie using set_chemical_TP instead of calculate) but no dice. This might be a slightly more involved bug.

jjderlatka commented 3 years ago

There is a note in Thermo.mixture Docs recommending switching to Thermo.flash but this seems to be not a straightforward transition. It needs to be decided whether it's worth doing, currently, the temporary fix is forcing Thermo to version 0.1.40

dug20 commented 3 years ago

Updated bamboo so it no longer relies on thermo - the user needs to decide what they want to use to model transport properties.