search

cuspaceflight / bamboo

Cooling system modelling for liquid rocket engines.
GNU Affero General Public License v3.0
16 stars 4 forks source link

Allow custom values of theta_n #37

Closed codeflight1 closed 2 years ago

codeflight1 commented 2 years ago

This allows for values of theta_n outside of the graph

dug20 commented 2 years ago

I think you could get an attribute error in line 474, when trying to do print(a Nozzle object) - it will try to access self.theta_e_graph, but this might not have been set if "theta_n" is given as an input.

Might want to just add a line like self.theta_e_graph = float("NaN") after line 448

codeflight1 commented 2 years ago

Good point, should be fixed now.