cuspaceflight / firefish

CFD simulation software for Martlet 3
Apache License 2.0
5 stars 4 forks source link

Cylinder example #35

Closed boyuanxiao closed 8 years ago

boyuanxiao commented 8 years ago

This script runs rhoCentralFoam (with a Spalart-Allmaras turbulence model) for a cylinder The cylinder mesh is generated using mirrorMeshDict, I've changed the case script in order for tools to be able to take arguments, in this case 'noFuncionObjects' The drag coefficient is calculated for Rey = 10^6 to 10^7 (you can change the Reynolds number and data points), at the moment there is a dip, and then rise in the drag coefficients - ie what you'd expect for Rey = 10^5 to 10^6. If people are familiar with the S-A model, it'll be nice to have a look into the initial values I've put. It's also possible the mesh needs to be made finer near the boundary layer, but changing the grading didn't affect the results

At the moment this PR fails pylint because of two "trailing whitespace errors", but I used Sublime to remove these - and can't really see them on the lines which Pylint indicated.

rjw57 commented 8 years ago

There's a Sublime Text plugin which might help here. I've got VIM configured to display trailing whitespace and you can see it on lines 74 and 289 below:

screenshot from 2016-01-15 10-39-49

Other than that, :+1: for merging once the pylint check passes.

rjw57 commented 8 years ago

I've added a fix in rjw57/firefish@2a644cb433750134ced4eac6da8bf79731c79952. This is a good time to research git cherry-pick. Specifically:

$ git fetch https://github.com/rjw57/firefish
$ git cherry-pick 2a644cb433750134ced4eac6da8bf79731c79952
rjw57 commented 8 years ago

Super. Merged.