custom-cards / button-card

❇️ Lovelace button-card for home assistant
MIT License
1.93k stars 233 forks source link

Button-card broken in HA 2023.4 (beta) Dont update if you use button-card #669

Closed Mariusthvdb closed 1 year ago

Mariusthvdb commented 1 year ago

Checklist

Describe the bug A clear and concise description of what the bug is.

2023.4 beta launched today, and the many changes in the frontend cause button-card to no longer be functional.

according to Frontend dev this might be an issue:

Version of the carde Version:

To Reproduce This is the configuration I used:

Screenshots If applicable, add screenshots to help explain your problem.

Scherm­afbeelding 2023-03-30 om 09 20 41

Expected behavior A clear and concise description of what you expected to happen.

Seems obvious... ourDashboard to be functional with the best card around

Desktop (please complete the following information): Any

Smartphone (please complete the following information): Any

Additional context Add any other context about the problem here.

This seems to be a generic issue with the card, I didnt have a chance to find a specific detail yet, had to roll back to 2023.3.6 in order to have a functional frontend....

in the #beta on Discord it was mentioned that the same also applies to Decluttering-card and Apex-charts-card.

Hope you're still around RR, and can find the time to fix these so very fundamental cards.

tomlut commented 1 year ago

Cause: https://github.com/RomRider/apexcharts-card/issues/527#issuecomment-1489919658

Mariusthvdb commented 1 year ago

yes, and to make it directly available like @kulmegil found out in https://community.home-assistant.io/t/lovelace-button-card/65981/6839

replace:

querySelector(“app-drawer-layout partial-panel-resolver”)

with:

querySelector("app-drawer-layout partial-panel-resolver, mwc-drawer partial-panel-resolver")
guevara777 commented 1 year ago

I forked this repository, made the changes and tried to add it as a "custom repository to hacs.

That doesn't work image

Any ideas how to get the card back to work again?

I need help, please.

kulmegil commented 1 year ago

I'm not smart enough to actually provide more insightful help as I lack the experience, but here is the link for requirements: https://hacs.xyz/docs/publish/plugin

I'm pretty sure hacs needs to locate a valid build .js file (either attached to latest release or in repo root or /dist folder)

Not sure how crash with button-card already being a part of default repos list. (is unique repo name required?)

Mariusthvdb commented 1 year ago

I have it on good authority, we have to wait until Monday, and some mysterious dev will have a look and release a fix....so have some patience, (and until that time, edit the resource manually)

guevara777 commented 1 year ago

I have it on good authority, we have to wait until Monday, and some mysterious dev will have a look and release a fix....so have some patience, (and until that time, edit the resource manually)

This is wonderful news. I´ve used the button-card very often in my dashboard and it looks like shi... right now. Thank you very much! 💯

guevara777 commented 1 year ago

I have it on good authority, we have to wait until Monday, and some mysterious dev will have a look and release a fix....so have some patience, (and until that time, edit the resource manually)

I´ve edited the resource here: image

I´ve replaced image

with image

and restarted ha. Sadly it still looks the same.

What did i do wrong?

Mariusthvdb commented 1 year ago

you probably still have it in the HACS folder? and use the HACS resource techniques, which can not be fooled easily. ;-)

make a new resource, add it in another folder in www, and point the resources file to that new resource. You can do that in Yaml mode, or via the UI

guevara777 commented 1 year ago

you probably still have it in the HACS folder? and use the HACS resource techniques, which can not be fooled easily. ;-)

make a new resource, add it in another folder in www, and point the resources file to that new resource. You can do that in Yaml mode, or via the UI

you're right. It is still in the Hacs folder. I´ll try that. Thank you ❤️

Edit: Tried it and failed. Maybe i´m not experienced enough. I'll just wait and be grateful that someone is working on it ❤️

firstof9 commented 1 year ago

delete the .gz files first THEN edit the .js file.

Note: You just needed to replace "app-drawer-layout partial-panel-resolver" into "app-drawer-layout, mwc-drawer partial-panel-resolver" and it should work with both beta and previous versions as well.

RomRider commented 1 year ago

I'll fix that Monday, folks (as well as the 2 others)

Mariusthvdb commented 1 year ago

RomRider, you're the best! Do notice https://discord.com/channels/330944238910963714/427516175237382144/1091751687221424159 though....

OK, I know you will all hate me for doing this, but believe me it is better to do it now then later 😬 We will rename mwc-drawer to ha-drawer during the beta (hopefully next beta) This means all custom cards that where updated to mwc-drawer should now be updated again to ha-drawer

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version 3.5.0-dev.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version 3.5.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

RomRider commented 1 year ago

Note: I've updated it directly to use ha-drawer

Mariusthvdb commented 1 year ago

Great. Much appreciated! Beyond joy here.

modem158 commented 1 year ago

Anyone else still having this issue? I've updated to 3.5.0 and I'm using the cards with Lovelace Minimalist. Cleared cache and all that jazz to no avail.

kulmegil commented 1 year ago

@modem158 Can you confirm the version displayed in your browser devtools console when HA is loading is indeed 3.5.0? Untitled5

modem158 commented 1 year ago

@kulmegil looks like it's me. I connect to HA at work through Nabu Casa and for some reason that browser refused to show my cards all day (even with a cache clear and restart). It's working fine on my phone and at home. Strange behavior that I couldn't clear my cache at work and have it reload properly. I'll play some more tomorrow. Thanks for your reply.