search

custom-cards / button-entity-row

Adds buttons to call services to entity cards
103 stars 20 forks source link

New update doesn't show in hacs. #4

Closed jcwillox closed 5 years ago

jcwillox commented 5 years ago

It appears the hacs client will display the latest release as the latest version of the plugin, currently, the latest release is set as v0.1.3 whereas the latest version is v0.2.0. Adding a title to v0.2.0 should make it the latest release solving this issue.

TheLastProject commented 5 years ago

The thing is, 0.1.4 and 0.2.0 are tagged, but not marked as releases on GitHub. Quite easy to fix yeah, waiting for this too please :)

jcwillox commented 5 years ago

@paulbdavis

paulbdavis commented 5 years ago

Got it, sorry, I forgot about this step

nicop4 commented 5 years ago

Hi @paulbdavis Something might still be missing because I have the same issue. I just installed a fresh HA with HACS and installed 0.2.0 as first version of button-entity-row.

image

paulbdavis commented 5 years ago

Not sure why it's not updating properly. Looking at the HACS docs it seems that all the requirements have been met.

paulbdavis commented 5 years ago

@nicop4 @jcwillox @royto I just realized the latest release didn't have a "name" entered, that's the only other thing I can think of. Let me know if the version shows up properly in HACS for you now and I'll close the issue.

jcwillox commented 5 years ago

@paulbdavis that didn't appear to fix it. I did a little bit of digging and found that the api response from https://api.github.com/repos/custom-cards/button-entity-row/releases shows v0.1.4 as the first object, v0.2.0 as the second. When comparing to other repos they should be ordered with the latest release as the first object. Interestingly the published_at attribute for v0.1.4 is "2019-07-26T00:38:19Z" and for v0.2.0 its "2019-07-26T00:38:00Z" which could explain why they're out of order. After checking the HACS code, it appears they just grab the first object in the returned array, assuming it the be the latest. A new release may get it back in order?.

nicop4 commented 5 years ago

Still no change as well. I think @jcwillox is right about the github api ordering with Home Assistant. But when you query https://api.github.com/repos/custom-cards/button-entity-row/releases/latest it shows version 0.2.0. This api could be used, but I guess the change would be withing HACS code.

jcwillox commented 5 years ago

Still no change as well. I think @jcwillox is right about the github api ordering with Home Assistant. But when you query https://api.github.com/repos/custom-cards/button-entity-row/releases/latest it shows version 0.2.0. This api could be used, but I guess the change would be withing HACS code.

Agreed, I believe its an issue with the way HACS is retrieving the latest version, which is via api.get_releases(), as opposed to get_latest_release(). At least that's what I interpreted from their code if you're interested this is the function I believe is used to retrieve the latest release. I may open an issue if that turns out to be the case.

paulbdavis commented 5 years ago

So both of those releasese were on the same day. I don't recall but it's possible I made the 0.1.4 release after 0.2.0.

Either way, I should be merging a PR soon and will be tagging 0.3.0 which should fix the issue.

jcwillox commented 5 years ago

Yep new release appears to have solved the issue 👍