search

custom-cards / slider-button-card

A button card with integrated slider
MIT License
105 stars 16 forks source link

Fix scrolling on touchscreens #28

Closed Pajn closed 1 year ago

Pajn commented 1 year ago

Makes the slider work on touchscreens by allowing the browser to handle the y-axis

Fixes #27

Pajn commented 1 year ago

lockfile reverted

ScottG489 commented 1 year ago

@rohankapoorcom Would love to see this go through! I love the look and compactness of these cards over mushroom cards, but this is a pretty big annoyance on phones. Don't want to accidentally set my thermostat to 90 and not notice while trying to scroll real quick on my dashboard :)

Jimmypl007 commented 1 year ago

@rohankapoorcom Would love to see this go through!

In the meantime, they just added subviews to home assistant..

I have my lights and other slider controls in those at the moment.

ScottG489 commented 1 year ago

Hey @Pajn! Wondering what the reason was that you closed this? Was looking forward to this change.

Pajn commented 1 year ago

Cleaning a lot stalled PRs to make overview of open ones in https://github.com/pulls usable. It doesn't seem I can do enything more to get thi merged. Anyone is of course super free to pick this up if they see a way forward to get it mergerd.

ScottG489 commented 1 year ago

It's too bad no one reviewed this. I'm just considering forking the repo with this change applied.

BlackCube4 commented 1 year ago

Damn it, this is such a simple and fundamental feature. I would love this change!

rohankapoorcom commented 1 year ago

Hey @Pajn - sorry for the delay on this. Things have been crazy for me the last couple of months.

ScottG489 commented 1 year ago

Thanks so much @rohankapoorcom! When can we expect the next HACS release?

piit79 commented 1 year ago

Awesome! Can't wait for the next release :) Thanks!

rohankapoorcom commented 1 year ago

It was just released in v1.10.10

mainmind83 commented 1 year ago

This fix seems to fail on all shutter elements, so far it worked. It does not allow to select above the percentage in Android

https://user-images.githubusercontent.com/18678468/203043417-55561ab7-74e1-4261-b1cf-aeea0385e4e1.mp4

square: false columns: 2 type: grid cards: - type: custom:slider-button-card entity: light.0xcc86ecfffe4e988c_l2 slider: direction: left-right background: gradient use_state_color: true use_percentage_bg_opacity: false show_track: false toggle_on_click: false force_square: false show_name: true show_state: true compact: false icon: show: false use_state_color: false tap_action: action: more-info action_button: mode: toggle icon: mdi:power show: true show_spinner: true tap_action: action: toggle name: Luz test 2

Tammarko commented 1 year ago

This fix seems to fail on all shutter elements, so far it worked. It does not allow to select above the percentage in Android

Confirming same behaviour, the shutters are now difficult to control.

rohankapoorcom commented 1 year ago

Hey @Pajn - do you mind taking a look at this bug report with the cover elements?