search

custom-cards / slider-button-card

A button card with integrated slider
MIT License
105 stars 16 forks source link

Vertical Slider does not work properly on touchscreens #44

Closed gutiar-junky closed 10 months ago

gutiar-junky commented 1 year ago

Checklist:

Release with the issue: 1.10.10

Last working release (if known):

Browser and Operating System: Chrome (latest) Dev with touch device emulation Chrome on Android 12

Description of problem: I can only use touch and slide, if i start the touch event on the slider but then move my finger beside it to change the value. It is reproducable in the Chrome Dev tools when emulating a touch device. I’ve mad a video here to showcase the issue: https://static.n-hantke.de/slider-card-problem.mp4

(Also posted this at community.home-assistant.io)

Javascript errors shown in the web inspector (if applicable):

coleek commented 1 year ago

+1 on HA app for iOS

danleongjy commented 1 year ago

I was using @rohankapoorcom's fork at https://github.com/rohankapoorcom/slider-button-card until recently, and only ran into this issue when swapping out that version (1.10.7) for the latest (1.10.10) official HACS version. Reverting to 1.10.7 solved the issue for me.

coleek commented 1 year ago

+1 on reverting versions— thank you!

Reverting back to 1.10.9 resolved the issue for me. Looks like maybe a resurfaced regression with v1.10.10…

danleongjy commented 1 year ago

Confirmed that 1.10.9 does not have this issue. Looking at the changelog, it could be due to this?

rohankapoorcom commented 10 months ago

I think I've figured out how to fix this and pushed up a PR that should fix it (#54) while maintaining the functionality released in #28

danleongjy commented 10 months ago

Thanks for the good work maintaining this card! I have upgraded and it appears all good so far :)