custom-cards / slider-button-card

A button card with integrated slider
MIT License
105 stars 16 forks source link

input_number does not seem to be valid in v1.12.0 #63

Closed danielbrunt57 closed 10 months ago

danielbrunt57 commented 10 months ago

Checklist:

Release with the issue: v1.12.0 image

Last working release (if known): n/a

Browser and Operating System: MS Edge / Windows 11 Professional

Description of problem: image

Additional information:

type: vertical-stack
cards:
  - type: entities
    entities:
      - entity: cover.bedroom_blind
        type: custom:multiple-entity-row
        name: Bedroom
        show_state: false
        entities:
          - entity: input_number.bedroom_blind
            name: Preset
          - entity: sensor.bedroom_blind_battery
            name: Battery
          - entity: sensor.bedroom_blind_battery
            name: false
            icon: true
    show_header_toggle: false
    state_color: false
    card_mod:
      class: inline-card
  - type: custom:slider-button-card
    slider:
      direction: bottom-top
      background: gradient
      attribute: tilt
      use_state_color: true
      use_percentage_bg_opacity: true
      toggle_on_click: false
      show_track: true
      force_square: false
      invert: true
    action_button:
      mode: toggle
      show: false
    icon:
      show: false
    entity: cover.bedroom_blind
    show_state: true
    compact: tr
    show_name: false
    name: Bedroom
  - type: custom:slider-button-card
    slider:
      direction: left-right
      background: gradient
      use_state_color: false
      use_percentage_bg_opacity: false
      toggle_on_click: false
      show_track: false
      force_square: false
      invert: false
    icon:
      show: false
    entity: input_number.bedroom_blind
    show_state: true
    compact: true
    show_name: false
    name: Bedroom
rohankapoorcom commented 10 months ago

Hah - you are fast! You caught me between the merge and the publish & release. I intend to release this tomorrow alongside support for number entities.

danielbrunt57 commented 10 months ago

LOL! I was flipping back and forth between the main repo and your pull version and wasn't sure where to post, or what my problem was, since the main repo docs showed input_number! No worries, I'll sleep on it!!

danielbrunt57 commented 10 months ago

image

rohankapoorcom commented 10 months ago

Wow. I have no idea why there is a PR from the main branch on custom-cards/slider-button-card back to mattieha/slider-button-card's repo. https://github.com/mattieha/slider-button-card/pull/205. Looks like it's creating a lot of noise in your email!

danielbrunt57 commented 10 months ago

I don't mind the noise per-se but I'm certainly confused now! I was originally asked quite some time ago to create a PR for my Venetian Blind support #205 which I did, and left it open but I had no idea how to implement it. Then you seemed to start working on it and I now have all these notifications about my PR! Weird!

danielbrunt57 commented 10 months ago

image

rohankapoorcom commented 10 months ago

Maybe you picked the wrong branch? It looks like that PR is trying to merge the main branch from this repo into the original repo (mattieha's repo). So every time I merge something into the main branch here, it's getting appended to your PR.

rohankapoorcom commented 10 months ago

Going back to your original note in this issue though: I've just pushed out v1.13.0 - https://github.com/custom-cards/slider-button-card/releases/tag/v1.13.0. Once that builds (about 2 minutes), you should be able to test out input_number and number support!

danielbrunt57 commented 10 months ago

LOL. When it comes to github PR's I'll admit I could get confused by it all!

On Aug 16, 2023 12:28 a.m., Rohan Kapoor @.***> wrote:

Maybe you picked the wrong branch? It looks like that PR is trying to merge the main branch from this repo into the original repo (mattieha's repo). So every time I merge something into the main branch here, it's getting appended to your PR.

— Reply to this email directly, view it on GitHubhttps://github.com/custom-cards/slider-button-card/issues/63#issuecomment-1680101654, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AL4JU3KWT6KPOQEXI3CXOTDXVRZADANCNFSM6AAAAAA3SB6ARY. You are receiving this because you modified the open/close state.Message ID: @.***>

danielbrunt57 commented 10 months ago

I got v1.13..0 but still see the same problem...

On Aug 16, 2023 12:34 a.m., Rohan Kapoor @.***> wrote:

Going back to your original note in this issue though: I've just pushed out v1.13.0 - https://github.com/custom-cards/slider-button-card/releases/tag/v1.13.0. Once that builds (about 2 minutes), you should be able to test out input_number and number support!

— Reply to this email directly, view it on GitHubhttps://github.com/custom-cards/slider-button-card/issues/63#issuecomment-1680108710, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AL4JU3NLHY64KRUGR6VM35LXVRZWTANCNFSM6AAAAAA3SB6ARY. You are receiving this because you modified the open/close state.Message ID: @.***>

rohankapoorcom commented 10 months ago

Have you confirmed you've cleared your cache? When you load the page with the developer tools in your browser open, it should output the card name and version. Are you seeing v1.13.0 there?

image

Here's an example that's working for me:

image
type: custom:slider-button-card
entity: input_number.volume_increment
slider:
  direction: left-right
  background: gradient
  use_state_color: false
  use_percentage_bg_opacity: false
  show_track: false
  toggle_on_click: false
  force_square: false
show_name: true
show_state: true
compact: false
icon:
  show: true
  use_state_color: true
  tap_action:
    action: more-info
  icon: ''
action_button:
  mode: toggle
  icon: mdi:power
  show: true
  show_spinner: true
  tap_action:
    action: toggle
show_attribute: false
name: Input Number Test
danielbrunt57 commented 10 months ago

I had tried shift+reload page, Settings -> Privacy -> Clear browsing data -> Cached images and file,, killed Edge and restarted it but problem persisted. I just checked Chrome and it's okay. So this time I did shift+reload page, Settings -> Privacy -> Clear browsing data -> Cached images and files & also Clear browing data for Internet Explorer -> Temporary internet files, killed Edge and restarted it and now it's okay.

image