search

custom-cards / slider-button-card

A button card with integrated slider
MIT License
105 stars 16 forks source link

Support higher value resolution #66

Open jclsn opened 9 months ago

jclsn commented 9 months ago

Is your feature request related to a problem? Please describe. I am using the sliders for setting the temperature using input numbers. Unfortunately I can only set full degrees and would like to be able to set 0.1 degree steps. I have made a PR to the repo of @lizsugar once, but it was ignored. Here are the commits.

https://github.com/jclsn/slider-button-card/commits/main

It used to work quite well for me, but HA still wants me to update the card and then the feature is gone.

Describe the solution you'd like Make it possible to use a higher resolution than currently.

jlopez77 commented 1 month ago

I second this one. Slider should have the same precision as step value in input number, up to 0.01

jclsn commented 1 month ago

I think the repo here is abandoned

rohankapoorcom commented 1 month ago

It's not abandoned. I'm just the only one maintaining it and finding time is challenging.

jlopez77 commented 1 month ago

Thank you both for the quick response.

Rohan, maybe it's a good idea to take a look at the commit proposed by jclsn, I've been taking a bit of a look at it and it looks solid.

Thanks!

El mié, 29 may 2024 a las 7:26, Rohan Kapoor @.***>) escribió:

It's not abandoned. I'm just the only one maintaining it and finding time is challenging.

— Reply to this email directly, view it on GitHub https://github.com/custom-cards/slider-button-card/issues/66#issuecomment-2136538958, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACQIBIRCS464VDPFIE463KTZEVRJNAVCNFSM6AAAAAA4OOAZIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZWGUZTQOJVHA . You are receiving this because you commented.Message ID: @.***>

rohankapoorcom commented 1 month ago

@jclsn do you mind opening a pull request to this repo? Happy to test and merge it in the next couple of days if so.

jclsn commented 1 month ago

@rohankapoorcom I think I opened one against Liz's fork or something once. Don't remember anymore. It worked, but tbh I didn't know what I was doing there. Just tweaked some values until it worked.

jclsn commented 1 month ago

Oh yeah, I mentioned it there. Will try to take care of it on the weekend and make a clean PR

jclsn commented 1 month ago

There you go https://github.com/custom-cards/slider-button-card/pull/76