search

custom-cards / slider-button-card

A button card with integrated slider
MIT License
105 stars 16 forks source link

Add Support for input_number domain #7

Closed lizsugar closed 10 months ago

lizsugar commented 2 years ago

This adds support for the input_number domain and makes the entities far far easier to manage on a mobile touch display vs. the builtin entities card.

image

One note: There is a current oustanding bug where if the input_number.entity.min value is not cleanly divisible by the input_number.entity.step value, then the slider card is off by an amount. If your input_number has min = 5, max = 25, step = 5 then it will work just fine. But if the step is 2, then it will be off. This also has the side effect of changing the input_number to an "illegal" value when modified via slider-button-card. Step = 1 always works.

If anyone has any insight I would appreciate the help. Otherwise, I am submitting as is, because it is largely functional right now.

Closes #18

ivancristina commented 1 year ago

Hi! @lizsugar, I was using your mod till now and just happily noticed you are now an official contributor! Unfortunately passing to this fork, the input_number support disappeared, could the PR be merged? Thank you very much!

ScottG489 commented 1 year ago

Would be great if this could get merged! Not sure if it's holding things up, but it looks like there are some merge conflicts you'll probably want to look at sooner than later @lizsugar :)

jclsn commented 1 year ago

"maintained fork"

It is faster to implement yourself what you need than waiting for this to ever happen...

rohankapoorcom commented 10 months ago

Closing, since https://github.com/custom-cards/slider-button-card/pull/61 is the rebase of this PR.