search

custom-cards / surveillance-card

A custom component for displaying camera feeds in the style of a surveillance system.
Apache License 2.0
244 stars 36 forks source link

[Feature:] Add screenshots #30

Closed KTibow closed 3 years ago

KTibow commented 4 years ago

Not a big priority issue, just a lot of card docs have them, and I don't know what the "style of a surveillance system" looks like.

niemyjski commented 4 years ago

It would be nice to trigger recording or screenshots, not sure how it would work or if it would prompt to save to your computer or just in local storage.

KTibow commented 4 years ago

You're right, that's a good idea, although I was thinking of screenshots for the docs (so you can see what it looks like).

Kedryn commented 3 years ago

So, still no screenshots? Do we have to install and configure all, to find out it isn't what we thought?

atrv7 commented 3 years ago

@niemyjski @KTibow I am working on adding the screenshot & recording functionalities. I will create a new PR and push my code tomorrow afternoon

Kedryn commented 3 years ago

@niemyjski @KTibow I am working on adding the screenshot & recording functionalities. I will create a new PR and push my code tomorrow afternoon

@atrv7 i think you misunderstood the request.

We are asking screenshots of what this addon looks like, in the in docs, not making screenshots with the surveillance-card

atrv7 commented 3 years ago

@Kedryn there are 2 issues here. There is already a PR that should resolve your screenshot documentation issue ( #35 ).

I am working on @niemyjski's suggestion to add screenshot/recording functionalities which @KTibow also agreed would be a nice feature

niemyjski commented 3 years ago

@Kedryn this is an open source project (and anyone could have provided an image including yourself). I think others like myself didn't want to share a screenshot of our houses... Thanks @KTibow for providing one

@atrv7 Sounds great!

atrv7 commented 3 years ago

@niemyjski @KTibow I created a PR to add the snapshot and burst record functionalities to this code base. Take a look and let me know if it is what you envisioned and to let me know if there are better ways of implementing parts of it. Happy to work on it some more if there are things you would like to be done differently

PR--> #37