search

custom-components / authenticated

A platform which allows you to get information about sucessfull logins to Home Assistant.
MIT License
82 stars 28 forks source link

Add Version to Manifest #66

Closed GuyKh closed 3 years ago

GuyKh commented 3 years ago

Solves Issue #65

ludeeus commented 3 years ago

This will require an update of that key for each version, which's not maintainable for me. Something like https://github.com/hacs/integration/blob/main/.github/workflows/release.yml needs to be added, but I understand that is too much to ask. I will do that eventually if no one beats me to it.

GuyKh commented 3 years ago

@ludeeus I took the liberty to beat you to it :)

ludeeus commented 3 years ago

Can you use this instead? https://github.com/custom-components/breaking_changes/blob/main/.github/workflows/release.yaml

GuyKh commented 3 years ago

@ludeeus Done. Now need to try this :)

ludeeus commented 3 years ago

I've used that exact file in 2 other repos, so should not be an issue

GuyKh commented 3 years ago

Strangely, upon merge, the action didn't run

ludeeus commented 3 years ago

It's not supposed to, it's run when a release is released

ludeeus commented 3 years ago

https://github.com/custom-components/authenticated/runs/2047537506?check_suite_focus=true

GuyKh commented 3 years ago

Ahhhhh. Good to know!