Ernst79
commented
2 years ago Temperature for your sensor is parsed with this part of the code in https://github.com/custom-components/ble_monitor/blob/master/custom_components/ble_monitor/ble_parser/govee.py
def decode_temps(packet_value: int) -> float:
"""Decode potential negative temperatures."""
# https://github.com/Thrilleratplay/GoveeWatcher/issues/2
if packet_value & 0x800000:
return float((packet_value ^ 0x800000) / -100)
return float(packet_value / 10000)So, it seems that there is some error in this part. One possibility could be that the /100 should be /10000, but you end up with -13.8 instead of -15.2.
Could you do me a favor, and add a logger line like this, restart HA and get some of the errors from the HA log. Also report the temperature you would have expected, based on the Govee app (make sure there is not a temperature correction added in the app).
def decode_temps(packet_value: int) -> float:
"""Decode potential negative temperatures."""
# https://github.com/Thrilleratplay/GoveeWatcher/issues/2
_LOGGER.error("Govee temperature reading: %s", packet_value)
if packet_value & 0x800000:
return float((packet_value ^ 0x800000) / -100)
return float(packet_value / 10000)
krayj
I have 6 govee H5075 BLE climate sensing devices to test with. This repros on all of them.
[repro]
[results]
[additional notes]
I think that this device reports its actual temperature in Celsius and that when it starts reporting a negative number that it breaks something in the integration.
I should also point out that I was previously using the govee-specific HACS integration without issues and only started experiencing this issue when I decommissioned my use of the govee integration and replaced it with this one... so I have high confidence there is nothing wrong with my physical sensor device and that the problem is directly related to this integration.
The manufacturer of this sensor claims it's capable of accurately reporting temperatures as low as -5f (which would be -20.55c). I've personally seen it successfully report temps as low as 0f to 5f range (with the previous integration)
after enabling debugging in configuration.yml, I'm seeing some pretty wild entries for this sensor:
2021-10-28 12:39:09 DEBUG (MainThread) [custom_components.ble_monitor.sensor] Data measuring sensor received: {'firmware': 'Govee', 'temperature': -1384.71, 'humidity': 7.9, 'battery': 63, 'rssi': -54, 'mac': 'A4C138674C11', 'type': 'H5072/H5075', 'packet': 'no packet id', 'data': True}
(connecting via the govee app is showing something in the 4.5f (-15.2c) temp range, so the value -1384.71 is not inline with what the actual sensor is reporting)
[expectation] the integration should not fail when the sensor reports data in negative numbers