search

custom-components / custom_updater

[DEPRECATED]📦 A component which allows you to track and update custom cards/components and python_scripts
MIT License
166 stars 66 forks source link

VOTE: Change the structure. #133

Closed ludeeus closed 5 years ago

ludeeus commented 5 years ago

_Spin-off from https://github.com/custom-components/custom_updater/issues/131_

Issue:

Unable to find services.yaml for the custom_updater integration

This component is just a single file directly in the custom_components dir. To comply with recent changes this would need to change into something like blueprint

Add your vote as a reaction to this:

👍 Change the structure of this component (This WILL be a breaking change.) 👎 Leave it, it's just a warning. 👀 No opinion.

I'll leave this open until Sunday and will do the action based of the result then.

DavidFW1960 commented 5 years ago

So my opinion is that it should follow the structure for custom components and if that’s a breaking change so be it... I assume it’s not possible for both approaches to coexist? Probably whatever you do you’re going to upset someone. It seems that eventually this change will be forced anyway? If so I’d prefer to have my pain now.... Thanks for the explanation anyway. I’m good with whatever you decide even though I’d like to get rid of the warning.

ludeeus commented 5 years ago

I don't see a reason for this to be forced, but I have been wrong before. There can certainly be more than one "styles" of this, but I will only support one, and that is this one. Or the upcoming HACS if I ever get the time to finish that.

stepanov1975 commented 5 years ago

I think it will be better if everyone will aline with the recommended style. Chaos usually not a good thing.

ludeeus commented 5 years ago

So I guess folks really like breaking changes 🤷‍♂️ image Will get started on that when some time free up, probably not until Sunday/Monday (UTC)

stepanov1975 commented 5 years ago

We like order :)

DavidFW1960 commented 5 years ago

Hahahahaha!!!! No ambiguity there is there. Lol.

rpitera commented 5 years ago

Honestly, whatever keeps this component going I will do. I can't imagine life without it.