search

custom-components / grocy

Custom Grocy integration for Home Assistant
Apache License 2.0
156 stars 47 forks source link

Invalid version number prevents integration v4.3.3b from starting #223

Closed marcelvriend closed 2 years ago

marcelvriend commented 2 years ago

Unless all relevant information is provided, I can't help you

Describe the bug With #221 the integration won't start, unless the version number is valid for HA. Sorry, I should have mentioned that in the PR. The 'b' postfix makes it invalid for HA.

The custom integration 'grocy' does not have a valid version key (v4.3.3b) in the manifest file and was blocked from loading. See https://developers.home-assistant.io/blog/2021/01/29/custom-integration-changes#versions for more details

Expected behavior Versioning without 'b' will fix it. @isabellaalstrom Can you do a release without 'b' from now on? Of course, you can still make it a pre-release.

To Reproduce Steps to reproduce the behavior:

Install latest beta v4.3.3b.

ludeeus commented 2 years ago

v4.3.3b[0-9] should also be valid

isabellaalstrom commented 2 years ago

Fixed, re-released as v4.3.3