Closed marcelvriend closed 2 years ago
@isabellaalstrom, would you like to take a look at it? Also curious what you think about the possible breaking change.
Might do a production release of the current beta, before eventually merging this?
For the JSON decoder, inherit the one from Core bin in a custom decoder so we can have no breaking change and still fall back to it
If we can do it like @ludeeus says, without breaking change that would be best. Otherwise like you say, a production release of current beta before. I might do that now anyway? I am running beta with no issues.
Yes, will do that. Production release is fine, from the 300 users with analytics enabled 50 are on the beta and I haven't seen any issues.
Commit pushed with a custom JSON encoder that inherits from the HA Core ExtendedJSONEncoder, so no more breaking changes.
As I do not use this integration, and further reviews have to be done by @isabellaalstrom
@isabellaalstrom, are you still waiting for something or just haven't had time to review yet?
Oh crap I missed this entirely! On vacay right now. Will look at it asap.
I looked the code over, and think it looks good, but I'm not all that great with python really (😬) so I'm gonna merge it, release a pre-release and try it out!
This should be version 5.0.0, right? Since breaking etc
Edit: Forgot the breaking changes was taken out (?). Maybe continue on v4 then
Thanks! There are no breaking changes indeed.
Proposed changes
No breaking changes.
Out of scope issues
The mechanism to prevent this was already broken, so nothing has changed in that regard. Although easy to fix the bug, it still ignores time zones and will likely cause refresh issues for many users. Needs more attention and therefore removed it for now.