Drop loop kwarg from async_timeout.timeout

custom-components / healthchecksio

Update and display the status of your healthchecks.io checks.

MIT License

52 stars 9 forks source link

Closed drthanwho closed 2 years ago

drthanwho commented 2 years ago

In 2021.12 aiohttp is bumped to 3.8.0 (#58974) which has async_timeout 4.0.0 which in turn drops the loop= kwarg and will fail if its passed

(150 deprecation warnings in 12 hours 😅)

This fixes #23

ludeeus commented 2 years ago

Why draft?

drthanwho commented 2 years ago

you'd then be saying it can't be merged yet 😜

ludeeus commented 2 years ago

Nah, this has no dependency on HA version.

drthanwho commented 2 years ago

Nah, this has no dependency on HA version.

Aaah I'm slowly learning