search

custom-components / healthchecksio

Update and display the status of your healthchecks.io checks.
MIT License
48 stars 9 forks source link

add `inlang` to make the contribution of translations easier #41

Closed felixhaeberle closed 9 months ago

felixhaeberle commented 1 year ago

Let me know what changes you request for merging this PR.

Description

This pull request adds the possibility for contributors and translators to manage translations in a UI instead of files with no overhead for the maintainers. Additionally, I fixed some translations.

To get a UI for translations contained in this repository, an inlang.config.js has been created at the root of the repository. Furthermore, I added the few missing translations. If you want, I can add a small i18n section to the documentation on the README.

Overview

The changes of this PR and a live instance of the editor can be previewed with the following link https://inlang.com/editor/github.com/felixhaeberle/healthchecksio. Note: This link should be changed to point to custom-components instead of felixhaeberle after this PR has been merged.

Limitations

Certain actions are slow Inlang is running entirely on git, giving tremendous CI/CD and contribution power to localization. That means that the whole healthchecksio repo is cloned into the browser which makes certain actions like the initial load and pushing changes slow. Those limitations will be fixed with future releases and require no input from healthchecksio.

232016041-ec0c3da3-94a9-4492-85dd-d8478c66d945 (1)

Preview

Preview the messages on https://inlang.com/editor/github.com/felixhaeberle/healthchecksio.

ludeeus commented 1 year ago

Thanks for your changes. Translations however it not something Im willing to deal with for this integration. When I eventually port it to core, it will get it.

felixhaeberle commented 1 year ago

@ludeeus Thank you for your quick reponse! 🙏 This is only a tiny change (one config file basically) and could lead to contributors can do the translation work. This would make this integration much more user friendly, like other HA integrations.

ludeeus commented 1 year ago

All changes start out "tiny" (that is not a contributing factor), and this adds maintenance I'm not willing to add now, It is also a system I'm not familiar with. If I were to add it, it would be localize (the same as HA itself uses).

felixhaeberle commented 1 year ago

@ludeeus Get it, thank you for elaborating on it! :)