search

custom-components / sensor.untappd

🍻 Untappd Integration
https://untappd.com/
MIT License
38 stars 10 forks source link

Platform not found: sensor.untappd #19

Closed Naesstrom closed 2 years ago

Naesstrom commented 5 years ago

I'm getting the following error in my travis-ci builds. The same error is also stopping me from updating hass.io

Failed config
  General Errors: 
    - Platform not found: sensor.untappd

Install location: custom_components/untappd/sensor.py

Configuration: https://github.com/Naesstrom/home_assistant/blob/master/packages/untappd.yaml

iantrich commented 5 years ago

I missed this one, @Naesstrom did you get this sorted out?

Naesstrom commented 5 years ago

Actually no, still getting the same error in Travis CI Don't have that problem with any of my other custom components so just confusing what's causing it!

garnern2 commented 5 years ago

Did you ever get a fix for this Naesstrom?

swetoast commented 5 years ago

ping @ludeeus @iantrich is there an issue with this component in the lastest revision at all ?

garnern2 commented 5 years ago

Leave this one open, close mine, even though mine is still very much an issue. Quite confusing.

It’s also not that I “upgraded,” but rather that I just installed the add-on. I’m willing to help debug, but ignoring that there is an issue is not a solution for an add-on that is purported to be currently supported/compatible.

I also went into more detail with my open issue.

iantrich commented 5 years ago

I don't do travis-ci builds and don't plan to debug this as the component seemingly works for actual installations

garnern2 commented 5 years ago

Except I have an “actual installation” and it does not work.

iantrich commented 5 years ago

Then why are you commenting on this issue saying you have the same problem?

garnern2 commented 5 years ago

I opened another issue stating that it was specifically different. Until it was closed with no resolution.

Sounds like that’s fodder for an internal discussion.

garnern2 commented 5 years ago

BTW, the symptoms I’m having are identical based on the limited information provided.

iantrich commented 5 years ago

You said to close it...https://github.com/custom-components/sensor.untappd/issues/19#issuecomment-515786638

garnern2 commented 5 years ago

That’s what I posted AFTER my issue was closed with no resolution. It was posted as a statement of irony...not a request.

ludeeus commented 5 years ago

ping @ludeeus @iantrich is there an issue with this component in the lastest revision at all ?

@swetoast no, some users (hassio & docker) may see this "issue" when validating the configuration.

Users relying on a CI for their workflow should add a requirements.txt file with all requirements from custom_components they use (they can find these in the manifest files of the integrations.) Then install those using python3 -m pip install -r requirements.txt before running config check.

This issue is not with this integration but in HA itself, and this issue should IMO be closed. AFAIK this will be fixed to the next version 0.97 (is already in dev)

swetoast commented 5 years ago

@garnern2 mind trying that ? if it works ill close this thread

swetoast commented 5 years ago

@ludeeus tnx for the info :)