Make zaptec an official HA integration?

custom-components / zaptec

zaptec charger custom component for home assistant

MIT License

67 stars 20 forks source link

Make zaptec an official HA integration? #129

Open sveinse opened 1 month ago

sveinse commented 1 month ago

Currently the zaptec integration is distributed via the HACS framework.

Would it be interesting to have zaptec as an official HA integration? I'd like to hear from the people that are using the integration. Migrating the zaptec integration from a HACS installable integration into a official HA integration will require considerable efforts. There is no point in doing it unless there is a need and would benefit our users.

What do you think? Is using HACS for this repo a burden for making use of zaptec?

c0mplex1 commented 1 month ago

For me personally it is not really an extra burden to use Zaptec integration via HACS, but I think that if the integration becomes part of HA OS it will work even more reliably than it is now. After all, your integration does not need HACS anymore.

dsmagghe commented 1 month ago

would be nice, but even nicer if the load balancer would also be able to balance multiple chargers at once. I see the last commit there was more then 9 months ago :(

Ghannes commented 4 weeks ago

Currently the zaptec integration is distributed via the HACS framework.

Would it be interesting to have zaptec as an official HA integration? I'd like to hear from the people that are using the integration. Migrating the zaptec integration from a HACS installable integration into a official HA integration will require considerable efforts. There is no point in doing it unless there is a need and would benefit our users.

What do you think? Is using HACS for this repo a burden for making use of zaptec?

What are the addiotional efforts?

sveinse commented 4 weeks ago

What are the addiotional efforts?

The Zaptec api itself must be separated out to a separate package on pypi
The coding standard must be updated to fulfil the Home Assistant quality scale
A series of PRs adding the Zaptec integration into ha-core. Here there is a convention to adding only one feature or file at a time, in order to make the changes small enough to be reviewable. So there will be many PRs and it will be waiting on collaborators able to approve.

More info here: https://developers.home-assistant.io/docs/creating_component_code_review

Hellowlol commented 4 weeks ago

It really not worth it imo

c0mplex1 commented 3 weeks ago

@sveinse Considering the huge amount of work that needs to be put into making the zaptec integration part of HA, I now also wonder if it is worth it. Will the adjustment and/or expansion of the integration remain as flexible as it is now, or will it become a sluggish process if it has to be approved by many collaborators first. Decisions, decisions, decisions.