search

custom-components / zaptec

zaptec charger custom component for home assistant
MIT License
66 stars 20 forks source link

Logo color #98

Closed jseedorff closed 1 month ago

jseedorff commented 8 months ago

Great plug-in, works perfect. Thanks!

Only small issue is logo color. It's hard to see on a dark background.

image

sveinse commented 8 months ago

I have been wondering about the same. However, the repo doesn't contain the artwork for the logo. @Hellowlol do you know how HA gets the logo?

danielkihlgren commented 7 months ago

@sveinse Logo can be found here https://github.com/home-assistant/brands/tree/master/custom_integrations/zaptec

sveinse commented 7 months ago

@danielkihlgren or anyone: Any proposals on what should be chosen as the artwork for Zaptec?

sveinse commented 2 months ago

Anyone up for the task to contribute new and improved artwork (that works in both light and dark mode) of the Zaptec logo? Here: https://github.com/home-assistant/brands/tree/master/custom_integrations/zaptec

c0mplex1 commented 1 month ago

Two examples added. one with a white border around the text one with grayed out text Is this a solution?

icon_gray icon_white_border logo_gray logo_white_border

jseedorff commented 1 month ago

Hi,

Could something similar to what Airthings have done be used:

[image: image.png]

[image: image.png]

That grey color seems to work well in both light and dark mode.

Best regards

Jakob Seedorff

Den tors. 10. okt. 2024 kl. 13.52 skrev c0mplex1 @.***>:

Two examples added. one with a white border around the text one with grayed out text Is this a solution?

icon_gray.png (view on web) https://github.com/user-attachments/assets/f82817e1-62cb-4592-a72d-d4f60bea6789 icon_white_border.png (view on web) https://github.com/user-attachments/assets/9e7d3343-ca3c-47d7-b1e6-07263f6458f6 logo_gray.png (view on web) https://github.com/user-attachments/assets/3ee5a3a5-e252-4d9d-9105-a087777cef14 logo_white_border.png (view on web) https://github.com/user-attachments/assets/cf7c3239-1c83-4974-a146-fbbab467219a

— Reply to this email directly, view it on GitHub https://github.com/custom-components/zaptec/issues/98#issuecomment-2404882531, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACE5NLMBX4KZ3XCTHQZWSUTZ2ZS6RAVCNFSM6AAAAABEZDDL72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBUHA4DENJTGE . You are receiving this because you authored the thread.Message ID: @.***>

-- Med venlig hilsen

Jakob Seedorff Mobil: +45 40171218 e-mail: @.***

sveinse commented 1 month ago

Game on. PR for changing the logos is underway: https://github.com/home-assistant/brands/pull/6002

I've used more recent logos and with both light and dark variants. Let's cross our finger for swift approval.

sveinse commented 1 month ago

This has been approved and merged 💪 , so we can all enjoy the new icons in our HAs already. Closing the issue.