customa / customa-discord

The most customizable Discord theme out there.
https://customa.github.io/
GNU General Public License v3.0
139 stars 18 forks source link

i like the light #15

Closed yemouu closed 5 years ago

yemouu commented 5 years ago

may wanna change some of the colors

ghostlydilemma commented 5 years ago

Requests for code structure: When you use any colors in this module try to keep it to the color variables, fixed values make it behave very iffy.

.inner-zqa7da::before{
    color: rgba(0, 0, 0, 0.2);
}

Stuff like this could easily be changed to

.inner-zqa7da::before{
    color: var(--ColFont:  #72767d);
}

.theme-light selector can (and should be removed whereever it is possible), the module only really works with White Theme Enabled anyways so it is redundant (therefore useless) code.

/* Fixes for 'Remove 2FA' 'Reset Voice Settings' and 'Change Phone Number?' buttons being to bright */
.lookOutlined-3sRXeN.colorRed-1TFJan {
    color: #f04747!important;
}
.theme-light .lookLink-9FtZy-.colorPrimary-3b3xI6 {
    color: #747f8d!important;
}

The last two issues seen here

ghostlydilemma commented 5 years ago

Requests for other bug fixes spotted:

On Role Save: grafik

The issue with the oddly colored lines in the User Popout is due to (for example Spotify or Twitch) backgrounds (green and violet respectively) which change the background color to a value which needs a white text color. In Dark mode that doesn't bother anyone since the text there is always white.

This also affects the Listening to Spotify or Rich Presence screens/known games so that needs a darker color as well. grafik

Same goes for the roles and note header which also need the new color.

One big bug is that the icons in the settings menu have the wrong color. That seems to be a typo from me though. To fix it replace:

/* Settings Modal Fix */
#user-settings .ui-standard-sidebar-view .sidebar-region .side-8zPYf6 div::before{
    -webkit-filter: invert(100%) brightness(70%)!important;
}

with:

/* Settings Modal Fix */
#user-settings .standardSidebarView-3F1I7i .sidebarRegion-VFTUkN .side-8zPYf6 div::before{
    -webkit-filter: invert(100%) brightness(70%)!important;
}

Also I am going to create an open bug for the opening animation of the button because that seems terribly out of place for some reason. Update: This is a problem from Base