Closed mrehan27 closed 2 years ago
Pull request title looks good π!
If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0
. If this pull request gets merged in, the next release of this project will be 1.1.0
. This pull request is not a breaking change.
All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.
To merge this pull request, add the label Ready to merge
to this pull request and I'll merge it for you.
Merging #134 (f50d8f8) into develop (b93c2dc) will increase coverage by
0.09%
. The diff coverage is68.18%
.
@@ Coverage Diff @@
## develop #134 +/- ##
=============================================
+ Coverage 57.02% 57.11% +0.09%
- Complexity 160 166 +6
=============================================
Files 84 87 +3
Lines 1752 1784 +32
Branches 204 210 +6
=============================================
+ Hits 999 1019 +20
- Misses 683 689 +6
- Partials 70 76 +6
Impacted Files | Coverage Ξ | |
---|---|---|
...omer/messagingpush/extensions/ContextExtensions.kt | 0.00% <0.00%> (ΓΈ) |
|
...tomer/messagingpush/extensions/StringExtensions.kt | 0.00% <0.00%> (ΓΈ) |
|
...ain/java/io/customer/sdk/di/CustomerIOComponent.kt | 54.83% <25.00%> (-0.60%) |
:arrow_down: |
...va/io/customer/sdk/di/CustomerIOSharedComponent.kt | 50.00% <50.00%> (ΓΈ) |
|
.../src/main/java/io/customer/sdk/CustomerIOShared.kt | 66.66% <66.66%> (ΓΈ) |
|
sdk/src/main/java/io/customer/sdk/CustomerIO.kt | 53.60% <75.00%> (+1.05%) |
:arrow_up: |
sdk/src/main/java/io/customer/sdk/util/Logger.kt | 100.00% <100.00%> (ΓΈ) |
|
...ava/io/customer/sdk/util/StaticSettingsProvider.kt | 100.00% <100.00%> (ΓΈ) |
|
...n/java/io/customer/sdk/util/DispatchersProvider.kt | 0.00% <0.00%> (-66.67%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Build available to test
Version: rehan-feat-shared-instance-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/
:tada: This PR is included in version 3.1.0-alpha.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
:tada: This PR is included in version 3.1.0-beta.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
:tada: This PR is included in version 3.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
Fall Cleaning 2022
Changes
CustomerIOSharedComponent
to hold instances of classes that can be initialized without any dependency. Currently, the graph contains only following classes and can hold more where needed.Logger
DispatchersProvider
CustomerIOShared
class to initialize our SDK on first access without any dependency and can be used to minimise challenged for delayed initializations, particularly helpful when building wrapper SDKs for non native frameworks