customerio / customerio-android

This is the official Customer.io SDK for Android.
MIT License
12 stars 9 forks source link

feat: in-app feature no longer requires orgId #163

Closed Shahroz16 closed 1 year ago

Shahroz16 commented 1 year ago

Closes: https://github.com/customerio/issues/issues/8414

Complete each step to get your pull request merged in. Learn more about the workflow this project uses.

ami-oss-ci commented 1 year ago

Pull request title looks good 👍!

If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.1.0. This pull request is not a breaking change.

All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.

To merge this pull request, add the label Ready to merge to this pull request and I'll merge it for you.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...
This project uses a special format for pull requests titles. Don't worry, it's easy! This pull request title should be in this format: ``` : short description of change being made ``` **If your pull request [introduces breaking changes](https://web.archive.org/web/20220725195319/https://nordicapis.com/what-are-breaking-changes-and-how-do-you-avoid-them/)** to the code, use this format: ``` !: short description of breaking change ``` where `` is one of the following: - `feat:` - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project. - `fix:` - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project. - `docs:` - This pull request is making documentation changes, only. - `refactor:` - A change was made that doesn't fix a bug or add a feature. - `test:` - Adds missing tests or fixes broken tests. - `style:` - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc) - `perf:` - Changes improve performance of the code. - `build:` - Changes to the build system (maven, npm, gulp, etc) - `ci:` - Changes to the CI build system (Travis, GitHub Actions, Circle, etc) - `chore:` - Other changes to project that don't modify source code or test files. - `revert:` - Reverts a previous commit that was made. ### Examples: ``` feat: edit profile photo refactor!: remove deprecated v1 endpoints build: update npm dependencies style: run formatter ``` Need more examples? Want to learn more about this format? [Check out the official docs](https://www.conventionalcommits.org/). **Note:** If your pull request does multiple things such as adding a feature _and_ makes changes to the CI server _and_ fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.
codecov[bot] commented 1 year ago

Codecov Report

Merging #163 (d16e2cf) into develop (44cc4d1) will increase coverage by 0.17%. The diff coverage is 48.38%.

@@              Coverage Diff              @@
##             develop     #163      +/-   ##
=============================================
+ Coverage      61.68%   61.86%   +0.17%     
- Complexity       205      210       +5     
=============================================
  Files             91       91              
  Lines           2028     2040      +12     
  Branches         258      258              
=============================================
+ Hits            1251     1262      +11     
- Misses           680      681       +1     
  Partials          97       97              
Impacted Files Coverage Δ
...ustomer/messaginginapp/provider/GistApiProvider.kt 0.00% <0.00%> (ø)
...io/customer/messaginginapp/ModuleMessagingInApp.kt 60.34% <45.45%> (+7.40%) :arrow_up:
...ssaginginapp/provider/GistInAppMessagesProvider.kt 60.00% <60.00%> (+3.75%) :arrow_up:
...o/customer/messagingpush/ModuleMessagingPushFCM.kt 69.23% <100.00%> (+1.23%) :arrow_up:
...ain/java/io/customer/sdk/api/TrackingHttpClient.kt 33.33% <0.00%> (-4.77%) :arrow_down:
...src/main/java/io/customer/sdk/queue/QueueRunner.kt 24.39% <0.00%> (-2.44%) :arrow_down:
...tomer/messaginginapp/MessagingInAppModuleConfig.kt 100.00% <0.00%> (+12.50%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github-actions[bot] commented 1 year ago

Build available to test Version: shahroz-remove-org-id-gist-SNAPSHOT Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

ami-ci commented 1 year ago

:tada: This PR is included in version 3.3.0-alpha.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

ami-ci commented 1 year ago

:tada: This PR is included in version 3.3.0-beta.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 3.3.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: