Closed mrehan27 closed 1 year ago
Pull request title looks good 👍!
If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0
. If this pull request gets merged in, the next release of this project will be 1.0.1
. This pull request is not a breaking change.
All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.
Merging #184 (14e84a0) into main (a410e6d) will decrease coverage by
0.52%
. The diff coverage is30.55%
.
@@ Coverage Diff @@
## main #184 +/- ##
============================================
- Coverage 63.52% 63.01% -0.52%
Complexity 218 218
============================================
Files 91 91
Lines 2051 2082 +31
Branches 263 270 +7
============================================
+ Hits 1303 1312 +9
- Misses 646 667 +21
- Partials 102 103 +1
Impacted Files | Coverage Δ | |
---|---|---|
...essagingpush/CustomerIOFirebaseMessagingService.kt | 0.00% <0.00%> (ø) |
|
...stomer/sdk/CustomerIOActivityLifecycleCallbacks.kt | 7.40% <0.00%> (-4.36%) |
:arrow_down: |
sdk/src/main/java/io/customer/sdk/CustomerIO.kt | 74.33% <81.81%> (+0.17%) |
:arrow_up: |
sdk/src/main/java/io/customer/sdk/queue/Queue.kt | 82.85% <100.00%> (+0.33%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Build available to test
Version: fix-android-12-opened-metrics-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/
I modified the title of the PR to explain why this commit exists instead of what it is doing in the code.
fixes: https://github.com/customerio/issues/issues/9483
Changes
instanceOrNull
method to support modules initializationCustomerIOFirebaseMessagingService
to initialize push module when we initialize SDK usingcontext