customerio / customerio-android

This is the official Customer.io SDK for Android.
MIT License
13 stars 9 forks source link

fix: added cleanup of previously instance before creating new one #185

Closed Shahroz16 closed 1 year ago

Shahroz16 commented 1 year ago

Due to lifecycle differences, multiple instances of the application lifecycle would be added. So we need to unregister old instances of callbacks and also garbage collect any other instance of before.

Complete each step to get your pull request merged in. Learn more about the workflow this project uses.

github-actions[bot] commented 1 year ago

Pull request title looks good 👍!

If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.0.1. This pull request is not a breaking change.

All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...
This project uses a special format for pull requests titles. Don't worry, it's easy! This pull request title should be in this format: ``` : short description of change being made ``` **If your pull request [introduces breaking changes](https://web.archive.org/web/20220725195319/https://nordicapis.com/what-are-breaking-changes-and-how-do-you-avoid-them/)** to the code, use this format: ``` !: short description of breaking change ``` where `` is one of the following: - `feat:` - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project. - `fix:` - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project. - `docs:` - This pull request is making documentation changes, only. - `refactor:` - A change was made that doesn't fix a bug or add a feature. - `test:` - Adds missing tests or fixes broken tests. - `style:` - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc) - `perf:` - Changes improve performance of the code. - `build:` - Changes to the build system (maven, npm, gulp, etc) - `ci:` - Changes to the CI build system (Travis, GitHub Actions, Circle, etc) - `chore:` - Other changes to project that don't modify source code or test files. - `revert:` - Reverts a previous commit that was made. ### Examples: ``` feat: edit profile photo refactor!: remove deprecated v1 endpoints build: update npm dependencies style: run formatter ``` Need more examples? Want to learn more about this format? [Check out the official docs](https://www.conventionalcommits.org/). **Note:** If your pull request does multiple things such as adding a feature _and_ makes changes to the CI server _and_ fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.
codecov[bot] commented 1 year ago

Codecov Report

Merging #185 (dd14915) into fix/android-12-opened-metrics (a410e6d) will increase coverage by 0.60%. The diff coverage is 100.00%.

@@                         Coverage Diff                         @@
##             fix/android-12-opened-metrics     #185      +/-   ##
===================================================================
+ Coverage                            63.52%   64.13%   +0.60%     
- Complexity                             218      227       +9     
===================================================================
  Files                                   91       91              
  Lines                                 2051     2158     +107     
  Branches                               263      284      +21     
===================================================================
+ Hits                                  1303     1384      +81     
- Misses                                 646      671      +25     
- Partials                               102      103       +1     
Impacted Files Coverage Δ
sdk/src/main/java/io/customer/sdk/CustomerIO.kt 78.02% <100.00%> (+3.86%) :arrow_up:

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github-actions[bot] commented 1 year ago

Build available to test Version: shahroz-lifecycle-cleanup-SNAPSHOT Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/