search

customerio / customerio-android

This is the official Customer.io SDK for Android.
MIT License
13 stars 9 forks source link

feat: dismiss in-app message #186

Closed Shahroz16 closed 1 year ago

Shahroz16 commented 1 year ago

closes: https://github.com/customerio/issues/issues/9931

Complete each step to get your pull request merged in. Learn more about the workflow this project uses.

github-actions[bot] commented 1 year ago

Pull request title looks good 👍!

If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.1.0. This pull request is not a breaking change.

All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...
This project uses a special format for pull requests titles. Don't worry, it's easy! This pull request title should be in this format: ``` : short description of change being made ``` **If your pull request [introduces breaking changes](https://web.archive.org/web/20220725195319/https://nordicapis.com/what-are-breaking-changes-and-how-do-you-avoid-them/)** to the code, use this format: ``` !: short description of breaking change ``` where `` is one of the following: - `feat:` - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project. - `fix:` - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project. - `docs:` - This pull request is making documentation changes, only. - `refactor:` - A change was made that doesn't fix a bug or add a feature. - `test:` - Adds missing tests or fixes broken tests. - `style:` - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc) - `perf:` - Changes improve performance of the code. - `build:` - Changes to the build system (maven, npm, gulp, etc) - `ci:` - Changes to the CI build system (Travis, GitHub Actions, Circle, etc) - `chore:` - Other changes to project that don't modify source code or test files. - `revert:` - Reverts a previous commit that was made. ### Examples: ``` feat: edit profile photo refactor!: remove deprecated v1 endpoints build: update npm dependencies style: run formatter ``` Need more examples? Want to learn more about this format? [Check out the official docs](https://www.conventionalcommits.org/). **Note:** If your pull request does multiple things such as adding a feature _and_ makes changes to the CI server _and_ fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.
github-actions[bot] commented 1 year ago

Hey, there @Shahroz16 👋🤖. I'm a bot here to help you.

⚠️ Pull requests into the branch main typically only allows changes with the types: fix. From the pull request title, the type of change this pull request is trying to complete is: feat. ⚠️

This pull request might still be allowed to be merged. However, you might want to consider make this pull request merge into a different branch other then main.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...
This project uses a special format for pull requests titles. Don't worry, it's easy! This pull request title should be in this format: ``` : short description of change being made ``` **If your pull request [introduces breaking changes](https://web.archive.org/web/20220725195319/https://nordicapis.com/what-are-breaking-changes-and-how-do-you-avoid-them/)** to the code, use this format: ``` !: short description of breaking change ``` where `` is one of the following: - `feat:` - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project. - `fix:` - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project. - `docs:` - This pull request is making documentation changes, only. - `refactor:` - A change was made that doesn't fix a bug or add a feature. - `test:` - Adds missing tests or fixes broken tests. - `style:` - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc) - `perf:` - Changes improve performance of the code. - `build:` - Changes to the build system (maven, npm, gulp, etc) - `ci:` - Changes to the CI build system (Travis, GitHub Actions, Circle, etc) - `chore:` - Other changes to project that don't modify source code or test files. - `revert:` - Reverts a previous commit that was made. ### Examples: ``` feat: edit profile photo refactor!: remove deprecated v1 endpoints build: update npm dependencies style: run formatter ``` Need more examples? Want to learn more about this format? [Check out the official docs](https://www.conventionalcommits.org/). **Note:** If your pull request does multiple things such as adding a feature _and_ makes changes to the CI server _and_ fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.
codecov[bot] commented 1 year ago

Codecov Report

Merging #186 (c5152a9) into main (fd75467) will decrease coverage by 0.02%. The diff coverage is 42.85%.

@@             Coverage Diff              @@
##               main     #186      +/-   ##
============================================
- Coverage     62.77%   62.75%   -0.02%     
- Complexity      218      219       +1     
============================================
  Files            91       91              
  Lines          2090     2097       +7     
  Branches        270      272       +2     
============================================
+ Hits           1312     1316       +4     
- Misses          675      678       +3     
  Partials        103      103
Impacted Files Coverage Δ
.../customer/messaginginapp/di/DIGraphMessaginIApp.kt 0.00% <0.00%> (ø)
...ustomer/messaginginapp/provider/GistApiProvider.kt 0.00% <0.00%> (ø)
...ssaginginapp/provider/GistInAppMessagesProvider.kt 56.75% <0.00%> (-3.25%) :arrow_down:
.../customer/messagingpush/di/DiGraphMessagingPush.kt 16.66% <33.33%> (-11.91%) :arrow_down:
...io/customer/messaginginapp/ModuleMessagingInApp.kt 62.29% <100.00%> (+2.97%) :arrow_up:
sdk/src/main/java/io/customer/sdk/CustomerIO.kt 74.33% <100.00%> (ø)
.../src/main/java/io/customer/sdk/CustomerIOConfig.kt 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

github-actions[bot] commented 1 year ago

Build available to test Version: shahroz-inapp-dismiss-SNAPSHOT Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/