customerio / customerio-android

This is the official Customer.io SDK for Android.
MIT License
13 stars 9 forks source link

refactor: make delivery HTTP payload strongly-typed #188

Closed levibostian closed 1 year ago

levibostian commented 1 year ago

Refactor to give a suggestion for this PR conversation.

github-actions[bot] commented 1 year ago

Pull request title looks good 👍!

If this pull request gets merged, it will not cause a new release of the software. Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.0.0. This pull request is not a breaking change.

All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...
This project uses a special format for pull requests titles. Don't worry, it's easy! This pull request title should be in this format: ``` : short description of change being made ``` **If your pull request [introduces breaking changes](https://web.archive.org/web/20220725195319/https://nordicapis.com/what-are-breaking-changes-and-how-do-you-avoid-them/)** to the code, use this format: ``` !: short description of breaking change ``` where `` is one of the following: - `feat:` - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project. - `fix:` - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project. - `docs:` - This pull request is making documentation changes, only. - `refactor:` - A change was made that doesn't fix a bug or add a feature. - `test:` - Adds missing tests or fixes broken tests. - `style:` - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc) - `perf:` - Changes improve performance of the code. - `build:` - Changes to the build system (maven, npm, gulp, etc) - `ci:` - Changes to the CI build system (Travis, GitHub Actions, Circle, etc) - `chore:` - Other changes to project that don't modify source code or test files. - `revert:` - Reverts a previous commit that was made. ### Examples: ``` feat: edit profile photo refactor!: remove deprecated v1 endpoints build: update npm dependencies style: run formatter ``` Need more examples? Want to learn more about this format? [Check out the official docs](https://www.conventionalcommits.org/). **Note:** If your pull request does multiple things such as adding a feature _and_ makes changes to the CI server _and_ fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.
github-actions[bot] commented 1 year ago

Build available to test Version: levi-in-app-click-tracking-refactor-SNAPSHOT Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

codecov[bot] commented 1 year ago

Codecov Report

Merging #188 (ba3750f) into shahroz/in-app-click-tracking (55a1836) will decrease coverage by 0.22%. The diff coverage is 0.00%.

@@                         Coverage Diff                         @@
##             shahroz/in-app-click-tracking     #188      +/-   ##
===================================================================
- Coverage                            63.38%   63.16%   -0.22%     
  Complexity                             218      218              
===================================================================
  Files                                   91       91              
  Lines                                 2059     2063       +4     
  Branches                               263      263              
===================================================================
- Hits                                  1305     1303       -2     
- Misses                                 654      658       +4     
- Partials                               100      102       +2     
Impacted Files Coverage Δ
...io/customer/messaginginapp/ModuleMessagingInApp.kt 59.32% <0.00%> (ø)
...java/io/customer/sdk/data/request/DeliveryEvent.kt 0.00% <0.00%> (ø)
sdk/src/main/java/io/customer/sdk/queue/Queue.kt 81.73% <0.00%> (ø)
...java/io/customer/sdk/repository/TrackRepository.kt 57.57% <0.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Shahroz16 commented 1 year ago

Appreciate the PR, closing this on account of this comment.

We can reopen, after getting a ticket so this can be tested by QA.