Closed mrehan27 closed 1 year ago
Pull request title looks good 👍!
If this pull request gets merged, it will not cause a new release of the software. Example: If this project's latest release version is 1.0.0
. If this pull request gets merged in, the next release of this project will be 1.0.0
. This pull request is not a breaking change.
All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.
Hey, there @mrehan27 👋🤖. I'm a bot here to help you.
⚠️ Pull requests into the branch main
typically only allows changes with the types: fix
. From the pull request title, the type of change this pull request is trying to complete is: chore
. ⚠️
This pull request might still be allowed to be merged. However, you might want to consider make this pull request merge into a different branch other then main
.
Merging #189 (f327376) into main (f8ff104) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #189 +/- ##
=========================================
Coverage 62.77% 62.77%
Complexity 218 218
=========================================
Files 91 91
Lines 2090 2090
Branches 270 270
=========================================
Hits 1312 1312
Misses 675 675
Partials 103 103
Build available to test
Version: rehan-java-layout-sample-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/
Why is the path to this sample app samples/java_layout/
? I was expecting it to be samples/java/
.
@levibostian java
is a keyword used by Android project e.g. src/main/java
files, it can sometimes conflict in refactoring and can be confusing for IDE. So I avoided using common keyword to be on safer side.
Also, it adds symmetry to sample apps name by following a pattern, e.g.
kotlin_compose
=> Kotlin + Composejava_layout
=> Java + Layout files
Part of https://github.com/customerio/issues/issues/9845
Changes
SampleApplication
andBaseActivity
to help reduce similar code