Closed Shahroz16 closed 1 year ago
Pull request title looks good 👍!
If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0
. If this pull request gets merged in, the next release of this project will be 1.0.1
. This pull request is not a breaking change.
All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.
Merging #190 (dc01993) into main (4ad1f35) will decrease coverage by
0.51%
. The diff coverage is30.55%
.
@@ Coverage Diff @@
## main #190 +/- ##
============================================
- Coverage 63.28% 62.77% -0.51%
Complexity 218 218
============================================
Files 91 91
Lines 2059 2090 +31
Branches 263 270 +7
============================================
+ Hits 1303 1312 +9
- Misses 654 675 +21
- Partials 102 103 +1
Impacted Files | Coverage Δ | |
---|---|---|
...essagingpush/CustomerIOFirebaseMessagingService.kt | 0.00% <0.00%> (ø) |
|
...stomer/sdk/CustomerIOActivityLifecycleCallbacks.kt | 7.40% <0.00%> (-4.36%) |
:arrow_down: |
sdk/src/main/java/io/customer/sdk/di/DiGraph.kt | 100.00% <ø> (ø) |
|
sdk/src/main/java/io/customer/sdk/CustomerIO.kt | 74.33% <81.81%> (+0.17%) |
:arrow_up: |
sdk/src/main/java/io/customer/sdk/queue/Queue.kt | 82.07% <100.00%> (+0.34%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Build available to test
Version: shahroz-synchronize-override-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/
I think we should release this fix soon 👀
While testing, we noticed there are multiple instances of
Queue
being created even inNative SDK
even though it's usinggetSingletonInstanceCreate
method. On further logging, it was observed, that it might be due to multithreading so we making this methodsynchronized
would fix it.Complete each step to get your pull request merged in. Learn more about the workflow this project uses.