Closed mrehan27 closed 1 year ago
Pull request title looks good π!
If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0
. If this pull request gets merged in, the next release of this project will be 1.0.1
. This pull request is not a breaking change.
All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.
Merging #204 (cd38594) into main (3ed104a) will decrease coverage by
0.83%
. The diff coverage is41.37%
.
@@ Coverage Diff @@
## main #204 +/- ##
============================================
- Coverage 63.52% 62.70% -0.83%
- Complexity 218 231 +13
============================================
Files 91 94 +3
Lines 2051 2145 +94
Branches 263 281 +18
============================================
+ Hits 1303 1345 +42
- Misses 646 691 +45
- Partials 102 109 +7
Impacted Files | Coverage Ξ | |
---|---|---|
.../customer/messaginginapp/di/DIGraphMessaginIApp.kt | 0.00% <0.00%> (ΓΈ) |
|
...ustomer/messaginginapp/provider/GistApiProvider.kt | 0.00% <0.00%> (ΓΈ) |
|
...ssaginginapp/provider/GistInAppMessagesProvider.kt | 56.75% <0.00%> (-3.25%) |
:arrow_down: |
...essagingpush/CustomerIOFirebaseMessagingService.kt | 0.00% <0.00%> (ΓΈ) |
|
...messagingpush/CustomerIOPushNotificationHandler.kt | 0.00% <0.00%> (ΓΈ) |
|
...omer/messagingpush/extensions/ContextExtensions.kt | 0.00% <0.00%> (ΓΈ) |
|
...stomer/sdk/CustomerIOActivityLifecycleCallbacks.kt | 7.40% <0.00%> (-4.36%) |
:arrow_down: |
...java/io/customer/sdk/data/request/DeliveryEvent.kt | 0.00% <0.00%> (ΓΈ) |
|
sdk/src/main/java/io/customer/sdk/di/DiGraph.kt | 100.00% <ΓΈ> (ΓΈ) |
|
...java/io/customer/sdk/repository/TrackRepository.kt | 57.57% <0.00%> (-10.29%) |
:arrow_down: |
... and 8 more |
Build available to test
Version: fix-gcm-delivered-metrics-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/
closes: https://github.com/customerio/issues/issues/10066
Changes
CustomerIOFirebaseMessagingReceiver
for trackingdelivered
using C2DM callbacks from GCMJvmStatic
to methods fromCustomerIOFirebaseMessagingService
context
to create and retrieve SDK instance in push modulePushTrackingUtil
to remove redundant code