Closed mrehan27 closed 1 year ago
Pull request title looks good 👍!
If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0
. If this pull request gets merged in, the next release of this project will be 1.0.1
. This pull request is not a breaking change.
All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.
Merging #213 (1b83090) into main (89794f3) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #213 +/- ##
=========================================
Coverage 62.66% 62.66%
Complexity 219 219
=========================================
Files 91 91
Lines 2097 2097
Branches 272 272
=========================================
Hits 1314 1314
Misses 678 678
Partials 105 105
Impacted Files | Coverage Δ | |
---|---|---|
sdk/src/main/java/io/customer/sdk/di/DiGraph.kt | 100.00% <ø> (ø) |
Build available to test
Version: fix-di-graph-key-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/
@Shahroz16 Agreed. I too initially tried with similar options first, but eventually decided to go with short-term fix to prevent any potential bugs first. We can discuss this more internally and see how to improve this in future.
Closing this as changes were locally merged to #204 earlier. Releasing #204 will release these changes as well.
closes: https://github.com/customerio/issues/issues/10311
Changes
DiGraph
keys instead of simple name to avoid duplication