Closed Shahroz16 closed 1 year ago
Pull request title looks good π!
If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0
. If this pull request gets merged in, the next release of this project will be 1.0.1
. This pull request is not a breaking change.
All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.
Merging #221 (56a55dd) into main (1e289d7) will decrease coverage by
13.21%
. The diff coverage is4.31%
.
@@ Coverage Diff @@
## main #221 +/- ##
=============================================
- Coverage 62.86% 49.65% -13.21%
- Complexity 234 237 +3
=============================================
Files 94 108 +14
Lines 2149 2775 +626
Branches 282 362 +80
=============================================
+ Hits 1351 1378 +27
- Misses 690 1282 +592
- Partials 108 115 +7
Impacted Files | Coverage Ξ | |
---|---|---|
...io/customer/messaginginapp/gist/GistEnvironment.kt | 0.00% <0.00%> (ΓΈ) |
|
...tomer/messaginginapp/gist/data/NetworkUtilities.kt | 0.00% <0.00%> (ΓΈ) |
|
...stomer/messaginginapp/gist/data/listeners/Queue.kt | 0.00% <0.00%> (ΓΈ) |
|
...ustomer/messaginginapp/gist/data/model/LogEvent.kt | 0.00% <0.00%> (ΓΈ) |
|
...p/gist/data/model/engine/EngineWebConfiguration.kt | 0.00% <0.00%> (ΓΈ) |
|
...ginginapp/gist/data/repository/GistQueueService.kt | 0.00% <0.00%> (ΓΈ) |
|
...saginginapp/gist/presentation/GistModalActivity.kt | 0.00% <0.00%> (ΓΈ) |
|
...ssaginginapp/gist/presentation/GistModalManager.kt | 0.00% <0.00%> (ΓΈ) |
|
...stomer/messaginginapp/gist/presentation/GistSdk.kt | 0.00% <0.00%> (ΓΈ) |
|
...tomer/messaginginapp/gist/presentation/GistView.kt | 0.00% <0.00%> (ΓΈ) |
|
... and 7 more |
Build available to test
Version: shahroz-merge-gist-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/
I do see only 1 lint error for messaginginapp
. I am going to assume that this lint error will be fixed before merging?
To speedup my review, I am assuming that all code inside of the
messaginginapp
module is a direct copy/paste from the Gist SDK. So, code that has already been approved. Is this correct?I have reviewed all other code in this PR. And if the assumption is correct, I approve.
@levibostian mostly yes, but like for the lint issue you provided above, had to readjust some code to not use the API 24 rather lower API version.
closes: https://github.com/customerio/issues/issues/10295