customerio / customerio-android

This is the official Customer.io SDK for Android.
MIT License
12 stars 9 forks source link

fix: migrate in-app module from gist to CIO #221

Closed Shahroz16 closed 1 year ago

Shahroz16 commented 1 year ago

closes: https://github.com/customerio/issues/issues/10295

github-actions[bot] commented 1 year ago

Pull request title looks good πŸ‘!

If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.0.1. This pull request is not a breaking change.

All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...
This project uses a special format for pull requests titles. Don't worry, it's easy! This pull request title should be in this format: ``` : short description of change being made ``` **If your pull request [introduces breaking changes](https://web.archive.org/web/20220725195319/https://nordicapis.com/what-are-breaking-changes-and-how-do-you-avoid-them/)** to the code, use this format: ``` !: short description of breaking change ``` where `` is one of the following: - `feat:` - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project. - `fix:` - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project. - `docs:` - This pull request is making documentation changes, only. - `refactor:` - A change was made that doesn't fix a bug or add a feature. - `test:` - Adds missing tests or fixes broken tests. - `style:` - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc) - `perf:` - Changes improve performance of the code. - `build:` - Changes to the build system (maven, npm, gulp, etc) - `ci:` - Changes to the CI build system (Travis, GitHub Actions, Circle, etc) - `chore:` - Other changes to project that don't modify source code or test files. - `revert:` - Reverts a previous commit that was made. ### Examples: ``` feat: edit profile photo refactor!: remove deprecated v1 endpoints build: update npm dependencies style: run formatter ``` Need more examples? Want to learn more about this format? [Check out the official docs](https://www.conventionalcommits.org/). **Note:** If your pull request does multiple things such as adding a feature _and_ makes changes to the CI server _and_ fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.
github-actions[bot] commented 1 year ago
# Sample app builds πŸ“± Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request. --- * java_layout: `shahroz/merge-gist (1689173220)` * kotlin_compose: `shahroz/merge-gist (1689173209)`
codecov[bot] commented 1 year ago

Codecov Report

Merging #221 (56a55dd) into main (1e289d7) will decrease coverage by 13.21%. The diff coverage is 4.31%.

@@              Coverage Diff              @@
##               main     #221       +/-   ##
=============================================
- Coverage     62.86%   49.65%   -13.21%     
- Complexity      234      237        +3     
=============================================
  Files            94      108       +14     
  Lines          2149     2775      +626     
  Branches        282      362       +80     
=============================================
+ Hits           1351     1378       +27     
- Misses          690     1282      +592     
- Partials        108      115        +7     
Impacted Files Coverage Ξ”
...io/customer/messaginginapp/gist/GistEnvironment.kt 0.00% <0.00%> (ΓΈ)
...tomer/messaginginapp/gist/data/NetworkUtilities.kt 0.00% <0.00%> (ΓΈ)
...stomer/messaginginapp/gist/data/listeners/Queue.kt 0.00% <0.00%> (ΓΈ)
...ustomer/messaginginapp/gist/data/model/LogEvent.kt 0.00% <0.00%> (ΓΈ)
...p/gist/data/model/engine/EngineWebConfiguration.kt 0.00% <0.00%> (ΓΈ)
...ginginapp/gist/data/repository/GistQueueService.kt 0.00% <0.00%> (ΓΈ)
...saginginapp/gist/presentation/GistModalActivity.kt 0.00% <0.00%> (ΓΈ)
...ssaginginapp/gist/presentation/GistModalManager.kt 0.00% <0.00%> (ΓΈ)
...stomer/messaginginapp/gist/presentation/GistSdk.kt 0.00% <0.00%> (ΓΈ)
...tomer/messaginginapp/gist/presentation/GistView.kt 0.00% <0.00%> (ΓΈ)
... and 7 more
github-actions[bot] commented 1 year ago

Build available to test Version: shahroz-merge-gist-SNAPSHOT Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

levibostian commented 1 year ago

I do see only 1 lint error for messaginginapp. I am going to assume that this lint error will be fixed before merging?

Shahroz16 commented 1 year ago

To speedup my review, I am assuming that all code inside of the messaginginapp module is a direct copy/paste from the Gist SDK. So, code that has already been approved. Is this correct?

I have reviewed all other code in this PR. And if the assumption is correct, I approve.

@levibostian mostly yes, but like for the lint issue you provided above, had to readjust some code to not use the API 24 rather lower API version.