Closed mrehan27 closed 1 year ago
Pull request title looks good 👍!
If this pull request gets merged, it will not cause a new release of the software. Example: If this project's latest release version is 1.0.0
. If this pull request gets merged in, the next release of this project will be 1.0.0
. This pull request is not a breaking change.
All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.
Merging #223 (f3a2a3e) into main (46189dd) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #223 +/- ##
=========================================
Coverage 62.68% 62.68%
Complexity 231 231
=========================================
Files 94 94
Lines 2144 2144
Branches 281 281
=========================================
Hits 1344 1344
Misses 691 691
Partials 109 109
Build available to test
Version: rehan-sample-apps-properties-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/
Background
Sample apps builds generated by actions used
local.properties
inside the app, but the code assumed thelocal.properties
file should be used from root project which resulted in inconsistency and apps failing to load properties when uploaded for distributionChanges
local.properties
located insamples
folder so same file can be reused by all apps and can be kept separate from SDK properties