Closed Shahroz16 closed 1 year ago
Pull request title looks good 👍!
If this pull request gets merged, it will not cause a new release of the software. Example: If this project's latest release version is 1.0.0
. If this pull request gets merged in, the next release of this project will be 1.0.0
. This pull request is not a breaking change.
All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.
Merging #224 (51065bd) into main (a3657aa) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #224 +/- ##
=========================================
Coverage 62.68% 62.68%
Complexity 231 231
=========================================
Files 94 94
Lines 2144 2144
Branches 281 281
=========================================
Hits 1344 1344
Misses 691 691
Partials 109 109
Build available to test
Version: shahroz-fix-kotlin-sample-app-crash-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/
Why was this change made?
Why was this change made?
Because otherwise, it would crash occasionally. ActivityResultLauncher
needs to be done on Activity creation, on Compose this was not being done on onCreate
as compose lifecycle differs so had to shift logic to Activity.
Complete each step to get your pull request merged in. Learn more about the workflow this project uses.