customerio / customerio-android

This is the official Customer.io SDK for Android.
MIT License
11 stars 9 forks source link

ci: sample apps using separate workspaces #236

Closed levibostian closed 1 year ago

levibostian commented 1 year ago

We need each sample app to work with different CIO workspaces.

See status of PR.

Made this before my EOD to get early reviews and ideas on how to fix proxyman config.

github-actions[bot] commented 1 year ago

Pull request title looks good 👍!

If this pull request gets merged, it will not cause a new release of the software. Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.0.0. This pull request is not a breaking change.

All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...
This project uses a special format for pull requests titles. Don't worry, it's easy! This pull request title should be in this format: ``` : short description of change being made ``` **If your pull request [introduces breaking changes](https://web.archive.org/web/20220725195319/https://nordicapis.com/what-are-breaking-changes-and-how-do-you-avoid-them/)** to the code, use this format: ``` !: short description of breaking change ``` where `` is one of the following: - `feat:` - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project. - `fix:` - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project. - `docs:` - This pull request is making documentation changes, only. - `refactor:` - A change was made that doesn't fix a bug or add a feature. - `test:` - Adds missing tests or fixes broken tests. - `style:` - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc) - `perf:` - Changes improve performance of the code. - `build:` - Changes to the build system (maven, npm, gulp, etc) - `ci:` - Changes to the CI build system (Travis, GitHub Actions, Circle, etc) - `chore:` - Other changes to project that don't modify source code or test files. - `revert:` - Reverts a previous commit that was made. ### Examples: ``` feat: edit profile photo refactor!: remove deprecated v1 endpoints build: update npm dependencies style: run formatter ``` Need more examples? Want to learn more about this format? [Check out the official docs](https://www.conventionalcommits.org/). **Note:** If your pull request does multiple things such as adding a feature _and_ makes changes to the CI server _and_ fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.
github-actions[bot] commented 1 year ago

Build available to test Version: levi-sample-apps-workspaces-SNAPSHOT Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

github-actions[bot] commented 1 year ago
# Sample app builds 📱 Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request. --- * kotlin_compose: `levi/sample-apps-workspaces (1688999851)` * java_layout: `levi/sample-apps-workspaces (1688999852)`
codecov[bot] commented 1 year ago

Codecov Report

Merging #236 (c5a7754) into main (deaa916) will decrease coverage by 34.72%. The diff coverage is n/a.

@@              Coverage Diff              @@
##               main     #236       +/-   ##
=============================================
- Coverage     62.86%   28.14%   -34.72%     
+ Complexity      234       56      -178     
=============================================
  Files            94       26       -68     
  Lines          2149      643     -1506     
  Branches        282      105      -177     
=============================================
- Hits           1351      181     -1170     
+ Misses          690      441      -249     
+ Partials        108       21       -87     

see 68 files with indirect coverage changes

levibostian commented 1 year ago

In this PR, I tried to get proxyman proxying setup for sample apps to make verifying the correct workspace faster.

Debug builds work in proxyman but CI builds do not.

I would prefer if proxyman works but debug and release builds made on the CI but it might not be possible?

If it's a fast fix, I would like to have that put into this PR. Else, remove the proxyman config and let's ship only the CI build sample app GH Action workflow.

Update: I pushed a commit as an attempt to make debug and release builds able to work with proxyman. I need to still test this on a device.

Update: I tested latest CI build on device. Proxyman works.