Closed levibostian closed 1 year ago
Pull request title looks good 👍!
If this pull request gets merged, it will not cause a new release of the software. Example: If this project's latest release version is 1.0.0
. If this pull request gets merged in, the next release of this project will be 1.0.0
. This pull request is not a breaking change.
All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.
Build available to test
Version: levi-sample-apps-workspaces-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/
Merging #236 (c5a7754) into main (deaa916) will decrease coverage by
34.72%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #236 +/- ##
=============================================
- Coverage 62.86% 28.14% -34.72%
+ Complexity 234 56 -178
=============================================
Files 94 26 -68
Lines 2149 643 -1506
Branches 282 105 -177
=============================================
- Hits 1351 181 -1170
+ Misses 690 441 -249
+ Partials 108 21 -87
In this PR, I tried to get proxyman proxying setup for sample apps to make verifying the correct workspace faster.
Debug builds work in proxyman but CI builds do not.
I would prefer if proxyman works but debug and release builds made on the CI but it might not be possible?
If it's a fast fix, I would like to have that put into this PR. Else, remove the proxyman config and let's ship only the CI build sample app GH Action workflow.
Update: I pushed a commit as an attempt to make debug and release builds able to work with proxyman. I need to still test this on a device.
Update: I tested latest CI build on device. Proxyman works.
We need each sample app to work with different CIO workspaces.
See status of PR.
Made this before my EOD to get early reviews and ideas on how to fix proxyman config.