Closed Shahroz16 closed 1 year ago
Pull request title looks good 👍!
If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0
. If this pull request gets merged in, the next release of this project will be 1.0.1
. This pull request is not a breaking change.
All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.
Merging #239 (3c1c41b) into main (3f02263) will decrease coverage by
33.27%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #239 +/- ##
=============================================
- Coverage 49.65% 16.39% -33.27%
+ Complexity 237 59 -178
=============================================
Files 108 40 -68
Lines 2775 1269 -1506
Branches 362 185 -177
=============================================
- Hits 1378 208 -1170
+ Misses 1282 1033 -249
+ Partials 115 28 -87
Build available to test
Version: shahroz-fix-android-duplicate-classes-error-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/
While randomly testing react native sample app, which had a lower Kotlin version we bumped into an issue.
It was caused because
lifecycle-runtime-ktx:2.6.1
is being compiled by Kotlin 1.8.10 while, our SDK is being compiled by 1.7.21. So our duplicate kotlin versions were being sent.So until, we upgrade the kotlin version to 1.8.10, we have to make sure all the dependencies being used are also compiled by our current kotlin version, 1.7.21.