customerio / customerio-android

This is the official Customer.io SDK for Android.
MIT License
11 stars 9 forks source link

fix: in-app messaging proguard rules missing #241

Closed levibostian closed 12 months ago

levibostian commented 12 months ago

Gist proguard settings didn't get copied over when in-app module code was migrated from Gist SDK into the CIO SDK. This PR adds those proguard rules back. Also enables proguard on sample apps so we can better test Release builds like customers are.

Fixes: https://github.com/customerio/opsbugs/issues/3627

github-actions[bot] commented 12 months ago

Pull request title looks good 👍!

If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.0.1. This pull request is not a breaking change.

All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...
This project uses a special format for pull requests titles. Don't worry, it's easy! This pull request title should be in this format: ``` : short description of change being made ``` **If your pull request [introduces breaking changes](https://web.archive.org/web/20220725195319/https://nordicapis.com/what-are-breaking-changes-and-how-do-you-avoid-them/)** to the code, use this format: ``` !: short description of breaking change ``` where `` is one of the following: - `feat:` - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project. - `fix:` - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project. - `docs:` - This pull request is making documentation changes, only. - `refactor:` - A change was made that doesn't fix a bug or add a feature. - `test:` - Adds missing tests or fixes broken tests. - `style:` - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc) - `perf:` - Changes improve performance of the code. - `build:` - Changes to the build system (maven, npm, gulp, etc) - `ci:` - Changes to the CI build system (Travis, GitHub Actions, Circle, etc) - `chore:` - Other changes to project that don't modify source code or test files. - `revert:` - Reverts a previous commit that was made. ### Examples: ``` feat: edit profile photo refactor!: remove deprecated v1 endpoints build: update npm dependencies style: run formatter ``` Need more examples? Want to learn more about this format? [Check out the official docs](https://www.conventionalcommits.org/). **Note:** If your pull request does multiple things such as adding a feature _and_ makes changes to the CI server _and_ fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.
github-actions[bot] commented 12 months ago
# Sample app builds 📱 Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request. --- * java_layout: `levi/in-app-release-builds (1689883677)` * kotlin_compose: `levi/in-app-release-builds (1689883663)`
codecov[bot] commented 12 months ago

Codecov Report

Merging #241 (acaf3c3) into main (e9b5d0c) will increase coverage by 29.55%. The diff coverage is n/a.

@@              Coverage Diff              @@
##               main     #241       +/-   ##
=============================================
+ Coverage     20.20%   49.76%   +29.55%     
- Complexity       27      237      +210     
=============================================
  Files            19      108       +89     
  Lines           480     2781     +2301     
  Branches         99      364      +265     
=============================================
+ Hits             97     1384     +1287     
- Misses          371     1282      +911     
- Partials         12      115      +103     

see 89 files with indirect coverage changes

github-actions[bot] commented 12 months ago

Build available to test Version: levi-in-app-release-builds-SNAPSHOT Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/