Closed mrehan27 closed 9 months ago
Pull request title looks good 👍!
If this pull request gets merged, it will not cause a new release of the software. Example: If this project's latest release version is 1.0.0
. If this pull request gets merged in, the next release of this project will be 1.0.0
. This pull request is not a breaking change.
All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.
Merging #249 (e9d8395) into rehan/push-click-behavior (50cd640) will decrease coverage by
1.18%
. Report is 1 commits behind head on rehan/push-click-behavior. The diff coverage is7.47%
.
@@ Coverage Diff @@
## rehan/push-click-behavior #249 +/- ##
===============================================================
- Coverage 50.78% 49.61% -1.18%
- Complexity 249 250 +1
===============================================================
Files 108 110 +2
Lines 2786 2858 +72
Branches 366 374 +8
===============================================================
+ Hits 1415 1418 +3
- Misses 1255 1322 +67
- Partials 116 118 +2
Files Changed | Coverage Δ | |
---|---|---|
...messagingpush/CustomerIOPushNotificationHandler.kt | 0.00% <0.00%> (ø) |
|
...push/activity/NotificationClickReceiverActivity.kt | 0.00% <0.00%> (ø) |
|
...sagingpush/extensions/ApplicationInfoExtensions.kt | 0.00% <ø> (ø) |
|
...ava/io/customer/messagingpush/util/DeepLinkUtil.kt | 8.82% <0.00%> (-0.07%) |
:arrow_down: |
...ustomer/messagingpush/MessagingPushModuleConfig.kt | 91.30% <71.42%> (-8.70%) |
:arrow_down: |
.../messagingpush/config/NotificationClickBehavior.kt | 100.00% <100.00%> (ø) |
Build available to test
Version: rehan-push-click-activity-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/
@levibostian I think the only deprecated code we are using in this PR is what isn't available on older APIs. I fixed one small issue. Please feel free to point any are that is still using deprecated code.
For tests, I think a lot of changes we made in this PR rely on Android OS callbacks. So testing them may be quite hard with mocks, but I do plan to write some tests. And they will probably be coming in the last PR for this feature (after wrapper ones).
I would prefer that tests get added to this PR because it does make reviewing much easier.
GitHub gives you annotations helping you find parts of the code missing tests. If a future PR was made adding tests, the annotations would not show up and therefore, would make reviewing the PR for missing tests much harder.
As far as the deprecations, I also use github annotations to highlight them. There are lint warnings that are annotated (see screenshot above). I suggest enabling them if you have not already.
The deprecations shown are for existing code, not the code added in this PR. Fixing the warnings is definitely a good idea, but this PR isn't the right place for those updates.
Holding up this PR for tests complicates testing and finalizing changes on wrapper SDKs. The PRs were split to keep them short and simplify reviews. I'll write tests after validating changes in the wrapper SDKs. Since this PR is merging into a feature PR, we can still use GitHub annotations to identify code that isn't covered with tests.
helps: https://github.com/customerio/issues/issues/10830
Changes
NotificationClickReceiverActivity
for handling notification clicksNotificationClickBehavior
for customizing notification click behaviorDeepLinkUtil
updates to avoid adding unwanted flags to intentsNotes
NotificationClickBehavior
may be re-reviewed after feature changes are complete so we have clear picture of there implementation and behavior with different sample apps