Closed mrehan27 closed 9 months ago
Pull request title looks good 👍!
If this pull request gets merged, it will not cause a new release of the software. Example: If this project's latest release version is 1.0.0
. If this pull request gets merged in, the next release of this project will be 1.0.0
. This pull request is not a breaking change.
All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.
Merging #250 (22f85cd) into rehan/push-click-behavior (f7665c1) will increase coverage by
0.83%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## rehan/push-click-behavior #250 +/- ##
===============================================================
+ Coverage 50.12% 50.95% +0.83%
+ Complexity 250 249 -1
===============================================================
Files 110 109 -1
Lines 2879 2769 -110
Branches 382 351 -31
===============================================================
- Hits 1443 1411 -32
+ Misses 1320 1240 -80
- Partials 116 118 +2
Files | Coverage Δ | |
---|---|---|
...messagingpush/CustomerIOPushNotificationHandler.kt | 0.00% <ø> (ø) |
|
...o/customer/messagingpush/ModuleMessagingPushFCM.kt | 68.00% <ø> (-1.24%) |
:arrow_down: |
...ngpush/lifecycle/MessagingPushLifecycleCallback.kt | 40.00% <ø> (+18.26%) |
:arrow_up: |
...ava/io/customer/messagingpush/util/DeepLinkUtil.kt | 0.00% <ø> (-8.83%) |
:arrow_down: |
...push/activity/NotificationClickReceiverActivity.kt | 0.00% <0.00%> (ø) |
Build available to test
Version: rehan-push-click-cleanup-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/
helps: https://github.com/customerio/issues/issues/10830
Changes
CustomerIOPushReceiver
in favor ofNotificationClickReceiverActivity
DeepLinkUtil
to remove unused code