fix: added exception handling for when browser doesn't exist

customerio / customerio-android

This is the official Customer.io SDK for Android.

MIT License

13 stars 9 forks source link

fix: added exception handling for when browser doesn't exist #271

Closed Shahroz16 closed 11 months ago

Shahroz16 commented 11 months ago

fixes: https://github.com/customerio/customerio-android/issues/270

Testing:

This is how i replicated, created a new emulator

Run the command

adb shell pm uninstall --user 0 com.google.android.webview

Verified the app didn't crash when an in-app was recieved.

github-actions[bot] commented 11 months ago

# Sample app builds 📱 Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request. --- * java_layout: `shahroz/fix-no-browser (1697550821)` * kotlin_compose: `shahroz/fix-no-browser (1697550822)`

codecov[bot] commented 11 months ago

Codecov Report

Merging #271 (2193b56) into main (7588700) will decrease coverage by 0.11%. The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main     #271      +/-   ##
============================================
- Coverage     50.84%   50.73%   -0.11%     
  Complexity      249      249              
============================================
  Files           108      108              
  Lines          2779     2785       +6     
  Branches        361      362       +1     
============================================
  Hits           1413     1413              
- Misses         1249     1255       +6     
  Partials        117      117

Files	Coverage Δ
...inginapp/gist/presentation/engine/EngineWebView.kt	`0.00% <0.00%> (ø)`

github-actions[bot] commented 11 months ago

Build available to test Version: shahroz-fix-no-browser-SNAPSHOT Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/