Closed stephen-pope-customer-io closed 6 months ago
Attention: 4 lines
in your changes are missing coverage. Please review.
Comparison is base (
f1bfc22
) 53.52% compared to head (8b3ac05
) 53.53%.
Files | Patch % | Lines |
---|---|---|
...stomer/messaginginapp/gist/data/listeners/Queue.kt | 20.00% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Build available to test
Version: spope-11967-duplicate-messages-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/
I think it would be simpler if the implementation was handled inside Queue.kt
instead of GistSdk.kt
. It even has a listener to onMessageShown
where we can add the queueId
to the list.
This has been updated and tested, ready for review.
Yeah, we should eventually implement a retry mechanism on failure and maybe persist this variable into user preferences.
The idea is to keep track of the shown messages by queueId (which is unique per message) and skip the shown ones
This is based on the same solution applied for gist-web: https://github.com/customerio/gist-web/pull/26
Task: https://github.com/customerio/issues/issues/11967
Complete each step to get your pull request merged in. Learn more about the workflow this project uses.