refactor: rename sdk module to tracking

customerio / customerio-android

This is the official Customer.io SDK for Android.

MIT License

11 stars 9 forks source link

refactor: rename sdk module to tracking #290

Closed mrehan27 closed 3 months ago

mrehan27 commented 3 months ago

helps: https://linear.app/customerio/issue/MBL-157/track-the-binary-size-of-our-android-sdk

Changes

apkScale was breaking for tracking module as the module name in setting.gradle was different from the artifact id, so renamed it to match the artifact id. This should not impact customers as the artifact id is unchanged.

github-actions[bot] commented 3 months ago

# Sample app builds 📱 Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request. --- * java_layout: `rehan/mbl-157-rename-tracking (1711552189)` * kotlin_compose: `rehan/mbl-157-rename-tracking (1711552197)`

github-actions[bot] commented 3 months ago

Build available to test Version: rehan-mbl-157-rename-tracking-SNAPSHOT Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

mrehan27 commented 3 months ago

@levibostian I agree. I avoided initially because it might change many files, and we already have plans to rename it with the data pipeline changes anyway. But I agree this only affects file paths, not the content. Tagging @Shahroz16 for his thoughts. If we all agree to proceed, I'm happy to change the name of the directory.

mrehan27 commented 3 months ago

Agreed. Given that our next immediate task involves working on the data pipelines for Android, I'd lean towards not changing the directory right now to minimize any risks.

mrehan27 commented 3 months ago

Merging this first so commit history accurately reflects the changes, as this isn't directly related to changes for binary size comparison.