customerio / customerio-android

This is the official Customer.io SDK for Android.
MIT License
13 stars 9 forks source link

refactor: moved sdk classes to datapipelines module #319

Closed mrehan27 closed 5 months ago

mrehan27 commented 5 months ago

part of MBL-214

Background

Since Kotlin extensions do not work the same way as Swift, keeping CustomerIO SDK files in core module and adding extensions in the datapipelines module poses challenges for customers. Kotlin users need to import an extension for every method, while the syntax for Java users becomes even more complicated. To address this, we decided to move CustomerIO class to datapipelines module for now. With the planned introduction of EventBus, we do not foresee the need for usage of CustomerIO directly from core elsewhere. In case the need arise in future, we can reevaluate and find alternatives to maintain better customer experience when integrating the SDK.

Changes

github-actions[bot] commented 5 months ago
# Sample app builds 📱 Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request. --- * java_layout: `rehan/mbl-214-core-to-cdp (1715003713)` * kotlin_compose: `rehan/mbl-214-core-to-cdp (1715003698)`
codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.79%. Comparing base (48c64c9) to head (7f7cb9b). Report is 16 commits behind head on feature/cdp.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature/cdp #319 +/- ## ================================================= - Coverage 54.45% 53.79% -0.67% + Complexity 282 276 -6 ================================================= Files 109 105 -4 Lines 2534 2489 -45 Branches 355 345 -10 ================================================= - Hits 1380 1339 -41 + Misses 1032 1031 -1 + Partials 122 119 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 5 months ago

Build available to test Version: rehan-mbl-214-core-to-cdp-SNAPSHOT Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

github-actions[bot] commented 5 months ago

📏 SDK Binary Size Comparison Report

No changes detected in SDK binary size ✅