chore: add logger to analytics in datapipelines module

customerio / customerio-android

This is the official Customer.io SDK for Android.

MIT License

13 stars 9 forks source link

chore: add logger to analytics in datapipelines module #320

Closed mrehan27 closed 5 months ago

mrehan27 commented 5 months ago

part of MBL-214

Changes

Added custom logger to analytics to ensure that log configurations align with the SDK
Updated sample apps to set logLevel when initializing the SDK with new SDK builder

github-actions[bot] commented 5 months ago

# Sample app builds 📱 Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request. --- * java_layout: `rehan/mbl-214-cdp-logger (1714984963)` * kotlin_compose: `rehan/mbl-214-cdp-logger (1714984968)`

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.79%. Comparing base (48c64c9) to head (d3e2833). Report is 15 commits behind head on feature/cdp.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## feature/cdp #320 +/- ## ================================================= - Coverage 54.45% 53.79% -0.67% + Complexity 282 276 -6 ================================================= Files 109 105 -4 Lines 2534 2489 -45 Branches 355 345 -10 ================================================= - Hits 1380 1339 -41 + Misses 1032 1031 -1 + Partials 122 119 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 5 months ago

Build available to test Version: rehan-mbl-214-cdp-logger-SNAPSHOT Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

github-actions[bot] commented 5 months ago

📏 SDK Binary Size Comparison Report

No changes detected in SDK binary size ✅

Shahroz16 commented 5 months ago

@mrehan27 the snapshots is failing

mrehan27 commented 5 months ago

@Shahroz16 Yeah, I noticed it too. Even though :samples:java_layout:assembleRelease works fine locally, but it seems to fail on CI since we started using it in sample app. Could it be because we have temporarily tweaked the package of CustomerIO or CustomerIOInstance without moving them to match package? 🤔 I can try pushing that if that fixes it for us.

mrehan27 commented 5 months ago

Merging this, and moving build failing discussion to #319 since builds are failing there too and it might be more relevant to fix the cause.