customerio / customerio-android

This is the official Customer.io SDK for Android.
MIT License
11 stars 9 forks source link

chore: sample apps api keys with prefix #344

Closed mrehan27 closed 1 month ago

mrehan27 commented 1 month ago

Background

I realized it's harder to connect both of these sample apps to different workspaces because of the way we currently fetch keys. So I made some changes that allow us to provide optional different keys for the sample apps, with fallback to current format so we can reuse the same keys as well. These changes shouldn't break anything on CI or on local machines for any developer.

Changes

Example local.properties File

# Used by both sample apps
apiKey=API_KEY
siteId=SITE_ID

# Ignored as both sample apps have overridden the value
cdpApiKey=CDP_API_KEY

# Used by Java Layout only
javaLayout_cdpApiKey=JAVA_CDP

# Used by Kotlin Compose only
kotlinCompose_cdpApiKey=KOTLIN_CDP
github-actions[bot] commented 1 month ago
# Sample app builds 📱 Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request. --- * java_layout: `rehan/sample-app-keys (1716463931)` * kotlin_compose: `rehan/sample-app-keys (1716463946)`
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.46%. Comparing base (48c64c9) to head (4d35944). Report is 35 commits behind head on feature/cdp.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature/cdp #344 +/- ## ================================================= - Coverage 54.45% 52.46% -2.00% + Complexity 282 272 -10 ================================================= Files 109 101 -8 Lines 2534 2394 -140 Branches 355 339 -16 ================================================= - Hits 1380 1256 -124 + Misses 1032 1019 -13 + Partials 122 119 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago

Build available to test Version: rehan-sample-app-keys-SNAPSHOT Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

github-actions[bot] commented 1 month ago

📏 SDK Binary Size Comparison Report

No changes detected in SDK binary size ✅