search

customerio / customerio-android

This is the official Customer.io SDK for Android.
MIT License
13 stars 9 forks source link

chore: separate non-test classes into support package #348

Closed mrehan27 closed 4 months ago

mrehan27 commented 4 months ago

Background

I realized it was hard to differentiate between test files and files containing helper code for writing tests. So I separated them to make it easier to differentiate.

Changes

github-actions[bot] commented 4 months ago
# Sample app builds 📱 Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request. --- * java_layout: `rehan/test-improvements-part-2 (1716536465)` * kotlin_compose: `rehan/test-improvements-part-2 (1716536465)`
codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.54%. Comparing base (48c64c9) to head (bd18d8e). Report is 38 commits behind head on feature/cdp.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature/cdp #348 +/- ## ================================================= - Coverage 54.45% 52.54% -1.92% + Complexity 282 272 -10 ================================================= Files 109 101 -8 Lines 2534 2394 -140 Branches 355 339 -16 ================================================= - Hits 1380 1258 -122 + Misses 1032 1019 -13 + Partials 122 117 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 4 months ago

Build available to test Version: rehan-test-improvements-part-2-SNAPSHOT Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

github-actions[bot] commented 4 months ago

📏 SDK Binary Size Comparison Report

No changes detected in SDK binary size ✅

mrehan27 commented 4 months ago

@Shahroz16 I don't think having a separate module just for helper test classes will help. I believe it will complicate our project structure and limit the ability to access internal classes within them. So I see more cons than pros in having a different module for this case. Can you please list the benefits you think this option will provide?